Source/core/page/EventSource.h - Issue 558283004: bindings: Pass IDL dictionary references instead of pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventSource.h

Issue 558283004: bindings: Pass IDL dictionary references instead of pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@dic-webmidi

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/EventSource.h

diff --git a/Source/core/page/EventSource.h b/Source/core/page/EventSource.h

index 9d1e1292ff336e99a4926d4db9a4c860915cdd08..fceacbbdf9b6f0cc24450af35e31027ea3e2f3d4 100644

--- a/Source/core/page/EventSource.h

+++ b/Source/core/page/EventSource.h

@@ -56,7 +56,7 @@ class EventSource FINAL : public RefCountedWillBeGarbageCollectedFinalized<Event

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(EventSource);

WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;

public:

- static PassRefPtrWillBeRawPtr<EventSource> create(ExecutionContext*, const String& url, const EventSourceInit*, ExceptionState&);

+ static PassRefPtrWillBeRawPtr<EventSource> create(ExecutionContext*, const String& url, const EventSourceInit&, ExceptionState&);

virtual ~EventSource();

static const unsigned long long defaultReconnectDelay;

@@ -91,7 +91,7 @@ public:

virtual bool hasPendingActivity() const OVERRIDE;

private:

- EventSource(ExecutionContext*, const KURL&, const EventSourceInit*);

+ EventSource(ExecutionContext*, const KURL&, const EventSourceInit&);

virtual void didReceiveResponse(unsigned long, const ResourceResponse&) OVERRIDE;

virtual void didReceiveData(const char*, int) OVERRIDE;

« no previous file with comments | « Source/core/css/FontFace.cpp ('k') | Source/core/page/EventSource.cpp » ('j') | no next file with comments »