Source/modules/webmidi/MIDIAccessInitializer.h - Issue 558283004: bindings: Pass IDL dictionary references instead of pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/MIDIAccessInitializer.h

Issue 558283004: bindings: Pass IDL dictionary references instead of pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@dic-webmidi

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webmidi/MIDIAccessInitializer.h

diff --git a/Source/modules/webmidi/MIDIAccessInitializer.h b/Source/modules/webmidi/MIDIAccessInitializer.h

index f4c3274d867d669d46196a60f98db153965e24b4..e6ef5bfb36da5b3f86a7921352871be338a86652 100644

--- a/Source/modules/webmidi/MIDIAccessInitializer.h

+++ b/Source/modules/webmidi/MIDIAccessInitializer.h

@@ -37,7 +37,7 @@ public:

, version(version) { }

};

- static ScriptPromise start(ScriptState* scriptState, const MIDIOptions* options)

+ static ScriptPromise start(ScriptState* scriptState, const MIDIOptions& options)

{

RefPtr<MIDIAccessInitializer> p = adoptRef(new MIDIAccessInitializer(scriptState, options));

p->keepAliveWhilePending();

@@ -59,7 +59,7 @@ public:

private:

ScriptPromise start();

- MIDIAccessInitializer(ScriptState*, const MIDIOptions*);

+ MIDIAccessInitializer(ScriptState*, const MIDIOptions&);

ExecutionContext* executionContext() const;

« no previous file with comments | « Source/core/testing/DictionaryTest.cpp ('k') | Source/modules/webmidi/MIDIAccessInitializer.cpp » ('j') | no next file with comments »