Source/bindings/scripts/v8_methods.py - Issue 558283004: bindings: Pass IDL dictionary references instead of pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 558283004: bindings: Pass IDL dictionary references instead of pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@dic-webmidi

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index 8541c9bd2210c5a75bc94404a26a66e7d52bd322..e65bd786e475a91e5bd56af90a80fcdaf115747d 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -290,6 +290,8 @@ def cpp_value(interface, method, number_of_arguments):

idl_type = argument.idl_type

if idl_type.name == 'EventListener':

return argument.name

+ if idl_type.is_dictionary:

+ return '*%s' % argument.name

if (idl_type.is_callback_interface or

idl_type.name in ['NodeFilter', 'NodeFilterOrNull',

'XPathNSResolver', 'XPathNSResolverOrNull']):

« no previous file with comments | « no previous file | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »