Source/modules/webmidi/NavigatorWebMIDI.h - Issue 558283004: bindings: Pass IDL dictionary references instead of pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/NavigatorWebMIDI.h

Issue 558283004: bindings: Pass IDL dictionary references instead of pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@dic-webmidi

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webmidi/NavigatorWebMIDI.h

diff --git a/Source/modules/webmidi/NavigatorWebMIDI.h b/Source/modules/webmidi/NavigatorWebMIDI.h

index a5e0d89e53bfc07737b2214d41f7a1e75e31d81d..67fe32f754e35224574d59d97b8f2ff3b2a006cf 100644

--- a/Source/modules/webmidi/NavigatorWebMIDI.h

+++ b/Source/modules/webmidi/NavigatorWebMIDI.h

@@ -47,8 +47,8 @@ class NavigatorWebMIDI FINAL : public NoBaseWillBeGarbageCollected<NavigatorWebM

public:

static NavigatorWebMIDI& from(Navigator&);

- static ScriptPromise requestMIDIAccess(ScriptState*, Navigator&, const MIDIOptions*);

- ScriptPromise requestMIDIAccess(ScriptState*, const MIDIOptions*);

+ static ScriptPromise requestMIDIAccess(ScriptState*, Navigator&, const MIDIOptions&);

+ ScriptPromise requestMIDIAccess(ScriptState*, const MIDIOptions&);

virtual void trace(Visitor*) OVERRIDE;

« no previous file with comments | « Source/modules/webmidi/MIDIAccessInitializer.cpp ('k') | Source/modules/webmidi/NavigatorWebMIDI.cpp » ('j') | no next file with comments »