Source/bindings/tests/results/core/V8TestObject.cpp - Issue 558283004: bindings: Pass IDL dictionary references instead of pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestObject.cpp

Issue 558283004: bindings: Pass IDL dictionary references instead of pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@dic-webmidi

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/tests/results/core/V8TestObject.cpp

diff --git a/Source/bindings/tests/results/core/V8TestObject.cpp b/Source/bindings/tests/results/core/V8TestObject.cpp

index c77ea4b3711f9ea72234cb897d1db87da0c9afab..e6fedf07d53ebb912220e2cb36c577a985e15ae0 100644

--- a/Source/bindings/tests/results/core/V8TestObject.cpp

+++ b/Source/bindings/tests/results/core/V8TestObject.cpp

@@ -8116,7 +8116,7 @@ static void overloadedMethodJ2Method(const v8::FunctionCallbackInfo<v8::Value>&

testDictionaryArg = TestDictionary::create();

}

- impl->overloadedMethodJ(testDictionaryArg);

+ impl->overloadedMethodJ(*testDictionaryArg);

}

static void overloadedMethodJMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

« no previous file with comments | « Source/bindings/scripts/v8_methods.py ('k') | Source/core/css/FontFace.h » ('j') | no next file with comments »