Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 522633002: Supervised users: Escape the URL only in permission requests sent through Sync (not Apiary). (Closed)

Created:
6 years, 3 months ago by Marc Treib
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Supervised users: Escape the URL only in permission requests sent through Sync (not Apiary). BUG=408936 Committed: https://crrev.com/43bfc099da2860c322d1dd55a715c26b36659e63 Cr-Commit-Position: refs/heads/master@{#292637}

Patch Set 1 #

Total comments: 2

Patch Set 2 : GURL #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M chrome/browser/supervised_user/permission_request_creator.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/permission_request_creator_apiary.h View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/permission_request_creator_apiary.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/permission_request_creator_sync.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/permission_request_creator_sync.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 1 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Marc Treib
treib@chromium.org changed reviewers: + bauerb@chromium.org
6 years, 3 months ago (2014-08-29 10:23:27 UTC) #1
Marc Treib
PTAL!
6 years, 3 months ago (2014-08-29 10:23:27 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/522633002/diff/1/chrome/browser/supervised_user/permission_request_creator_sync.cc File chrome/browser/supervised_user/permission_request_creator_sync.cc (right): https://codereview.chromium.org/522633002/diff/1/chrome/browser/supervised_user/permission_request_creator_sync.cc#newcode39 chrome/browser/supervised_user/permission_request_creator_sync.cc:39: const std::string& url_requested, Can you make this a GURL ...
6 years, 3 months ago (2014-08-29 10:28:58 UTC) #3
Marc Treib
https://codereview.chromium.org/522633002/diff/1/chrome/browser/supervised_user/permission_request_creator_sync.cc File chrome/browser/supervised_user/permission_request_creator_sync.cc (right): https://codereview.chromium.org/522633002/diff/1/chrome/browser/supervised_user/permission_request_creator_sync.cc#newcode39 chrome/browser/supervised_user/permission_request_creator_sync.cc:39: const std::string& url_requested, On 2014/08/29 10:28:58, Bernhard Bauer wrote: ...
6 years, 3 months ago (2014-08-29 10:36:26 UTC) #4
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 3 months ago (2014-08-29 11:02:34 UTC) #5
Bernhard Bauer
The CQ bit was unchecked by bauerb@chromium.org
6 years, 3 months ago (2014-08-29 11:02:39 UTC) #6
Bernhard Bauer
Sorry, the review app is being weird. LGTM
6 years, 3 months ago (2014-08-29 11:04:28 UTC) #7
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 3 months ago (2014-08-29 11:07:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/522633002/20001
6 years, 3 months ago (2014-08-29 11:08:40 UTC) #9
Marc Treib
The CQ bit was unchecked by treib@chromium.org
6 years, 3 months ago (2014-08-29 11:32:40 UTC) #10
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 3 months ago (2014-08-29 11:39:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/522633002/40001
6 years, 3 months ago (2014-08-29 11:39:47 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as a90e7df1bd35c7e50375fefc98849cb9f5feacdc
6 years, 3 months ago (2014-08-29 15:20:44 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:08:46 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/43bfc099da2860c322d1dd55a715c26b36659e63
Cr-Commit-Position: refs/heads/master@{#292637}

Powered by Google App Engine
This is Rietveld 408576698