Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4400)

Unified Diff: chrome/browser/supervised_user/supervised_user_service.cc

Issue 522633002: Supervised users: Escape the URL only in permission requests sent through Sync (not Apiary). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/supervised_user/permission_request_creator_sync.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/supervised_user/supervised_user_service.cc
diff --git a/chrome/browser/supervised_user/supervised_user_service.cc b/chrome/browser/supervised_user/supervised_user_service.cc
index d52f15962f170c4736036926c254f9527e4db0ae..8f0a559890127c54baf25371b298f2520469952f 100644
--- a/chrome/browser/supervised_user/supervised_user_service.cc
+++ b/chrome/browser/supervised_user/supervised_user_service.cc
@@ -43,7 +43,6 @@
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/user_metrics.h"
#include "google_apis/gaia/google_service_auth_error.h"
-#include "net/base/escape.h"
#include "ui/base/l10n/l10n_util.h"
#if defined(OS_CHROMEOS)
@@ -541,15 +540,9 @@ void SupervisedUserService::OnPermissionRequestIssued() {
}
void SupervisedUserService::AddAccessRequest(const GURL& url) {
- // Normalize the URL.
- GURL normalized_url = SupervisedUserURLFilter::Normalize(url);
-
- // Escape the URL.
- std::string output(net::EscapeQueryParamValue(normalized_url.spec(), true));
-
waiting_for_permissions_ = true;
permissions_creator_->CreatePermissionRequest(
- output,
+ SupervisedUserURLFilter::Normalize(url),
base::Bind(&SupervisedUserService::OnPermissionRequestIssued,
weak_ptr_factory_.GetWeakPtr()));
}
« no previous file with comments | « chrome/browser/supervised_user/permission_request_creator_sync.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698