Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: chrome/browser/supervised_user/permission_request_creator_sync.cc

Issue 522633002: Supervised users: Escape the URL only in permission requests sent through Sync (not Apiary). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/permission_request_creator_sync.cc
diff --git a/chrome/browser/supervised_user/permission_request_creator_sync.cc b/chrome/browser/supervised_user/permission_request_creator_sync.cc
index 55551429d94b6f89b2ae4abb23ca845d4fa9447c..328bf21c5d083ccd01beecca2fd4ac6bf4a587e5 100644
--- a/chrome/browser/supervised_user/permission_request_creator_sync.cc
+++ b/chrome/browser/supervised_user/permission_request_creator_sync.cc
@@ -8,6 +8,8 @@
#include "base/values.h"
#include "chrome/browser/supervised_user/supervised_user_settings_service.h"
#include "chrome/browser/supervised_user/supervised_user_shared_settings_service.h"
+#include "net/base/escape.h"
+#include "url/gurl.h"
using base::Time;
@@ -35,11 +37,12 @@ PermissionRequestCreatorSync::PermissionRequestCreatorSync(
PermissionRequestCreatorSync::~PermissionRequestCreatorSync() {}
void PermissionRequestCreatorSync::CreatePermissionRequest(
- const std::string& url_requested,
+ const GURL& url_requested,
const base::Closure& callback) {
- // Add the prefix.
+ // Escape the URL and add the prefix.
std::string key = SupervisedUserSettingsService::MakeSplitSettingKey(
- kSupervisedUserAccessRequestKeyPrefix, url_requested);
+ kSupervisedUserAccessRequestKeyPrefix,
+ net::EscapeQueryParamValue(url_requested.spec(), true));
scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue);

Powered by Google App Engine
This is Rietveld 408576698