chrome/browser/supervised_user/permission_request_creator_apiary.cc - Issue 522633002: Supervised users: Escape the URL only in permission requests sent through Sync (not Apiary).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/permission_request_creator_apiary.cc

Issue 522633002: Supervised users: Escape the URL only in permission requests sent through Sync (not Apiary). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/permission_request_creator_apiary.h ('k') | chrome/browser/supervised_user/permission_request_creator_sync.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/permission_request_creator_apiary.cc

diff --git a/chrome/browser/supervised_user/permission_request_creator_apiary.cc b/chrome/browser/supervised_user/permission_request_creator_apiary.cc

index bfbc0dd596295a27f2ea2fe33ab2ef744ff30b1e..afcb8569a6176ae1df18ab0a38eec859fc8db899 100644

--- a/chrome/browser/supervised_user/permission_request_creator_apiary.cc

+++ b/chrome/browser/supervised_user/permission_request_creator_apiary.cc

@@ -62,7 +62,7 @@ PermissionRequestCreatorApiary::CreateWithProfile(Profile* profile) {

}

void PermissionRequestCreatorApiary::CreatePermissionRequest(

- const std::string& url_requested,

+ const GURL& url_requested,

const base::Closure& callback) {

url_requested_ = url_requested;

callback_ = callback;

@@ -103,7 +103,7 @@ void PermissionRequestCreatorApiary::OnGetTokenSuccess(

base::DictionaryValue dict;

dict.SetStringWithoutPathExpansion("namespace", kNamespace);

- dict.SetStringWithoutPathExpansion("objectRef", url_requested_);

+ dict.SetStringWithoutPathExpansion("objectRef", url_requested_.spec());

dict.SetStringWithoutPathExpansion("state", kState);

std::string body;

base::JSONWriter::Write(&dict, &body);