Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6770)

Unified Diff: chrome/browser/supervised_user/permission_request_creator_apiary.h

Issue 522633002: Supervised users: Escape the URL only in permission requests sent through Sync (not Apiary). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/permission_request_creator_apiary.h
diff --git a/chrome/browser/supervised_user/permission_request_creator_apiary.h b/chrome/browser/supervised_user/permission_request_creator_apiary.h
index abed986c4f6177af29cc886fc7088a2b924e9446..70a71f4c9832cd2c702317a8605c8c686b4afe96 100644
--- a/chrome/browser/supervised_user/permission_request_creator_apiary.h
+++ b/chrome/browser/supervised_user/permission_request_creator_apiary.h
@@ -5,11 +5,13 @@
#ifndef CHROME_BROWSER_SUPERVISED_USER_PERMISSION_REQUEST_CREATOR_APIARY_H_
#define CHROME_BROWSER_SUPERVISED_USER_PERMISSION_REQUEST_CREATOR_APIARY_H_
-#include "chrome/browser/supervised_user/permission_request_creator.h"
+#include <string>
#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/supervised_user/permission_request_creator.h"
#include "google_apis/gaia/oauth2_token_service.h"
#include "net/url_request/url_fetcher_delegate.h"
+#include "url/gurl.h"
class Profile;
class SupervisedUserSigninManagerWrapper;
@@ -37,7 +39,7 @@ class PermissionRequestCreatorApiary : public PermissionRequestCreator,
Profile* profile);
// PermissionRequestCreator implementation:
- virtual void CreatePermissionRequest(const std::string& url_requested,
+ virtual void CreatePermissionRequest(const GURL& url_requested,
const base::Closure& callback) OVERRIDE;
private:
@@ -62,7 +64,7 @@ class PermissionRequestCreatorApiary : public PermissionRequestCreator,
scoped_ptr<SupervisedUserSigninManagerWrapper> signin_wrapper_;
base::Closure callback_;
net::URLRequestContextGetter* context_;
- std::string url_requested_;
+ GURL url_requested_;
scoped_ptr<OAuth2TokenService::Request> access_token_request_;
std::string access_token_;
bool access_token_expired_;

Powered by Google App Engine
This is Rietveld 408576698