chrome/browser/supervised_user/permission_request_creator_sync.h - Issue 522633002: Supervised users: Escape the URL only in permission requests sent through Sync (not Apiary).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/permission_request_creator_sync.h

Issue 522633002: Supervised users: Escape the URL only in permission requests sent through Sync (not Apiary). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/permission_request_creator_apiary.cc ('k') | chrome/browser/supervised_user/permission_request_creator_sync.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/permission_request_creator_sync.h

diff --git a/chrome/browser/supervised_user/permission_request_creator_sync.h b/chrome/browser/supervised_user/permission_request_creator_sync.h

index 2352aaa9eb4eaeb9f4b19302ca8d6ba31dee04d6..dbeb142b462d6799163ec9f87a3a473fa99efe37 100644

--- a/chrome/browser/supervised_user/permission_request_creator_sync.h

+++ b/chrome/browser/supervised_user/permission_request_creator_sync.h

@@ -5,9 +5,10 @@

#ifndef CHROME_BROWSER_SUPERVISED_USER_PERMISSION_REQUEST_CREATOR_SYNC_H_

#define CHROME_BROWSER_SUPERVISED_USER_PERMISSION_REQUEST_CREATOR_SYNC_H_

-#include "chrome/browser/supervised_user/permission_request_creator.h"

+#include <string>

#include "base/memory/scoped_ptr.h"

+#include "chrome/browser/supervised_user/permission_request_creator.h"

class SupervisedUserSettingsService;

class SupervisedUserSharedSettingsService;

@@ -22,7 +23,7 @@ class PermissionRequestCreatorSync : public PermissionRequestCreator {

virtual ~PermissionRequestCreatorSync();

// PermissionRequestCreator implementation:

- virtual void CreatePermissionRequest(const std::string& url_requested,

+ virtual void CreatePermissionRequest(const GURL& url_requested,

const base::Closure& callback) OVERRIDE;

private: