Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 51033004: add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning (Closed)

Created:
7 years, 1 month ago by reed1
Modified:
7 years, 1 month ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

add SK_ATTR_DEPRECATED -- will need to disable for chrome, since it triggers a warning BUG= R=robertphillips@google.com, senorblanco@chromium.org, vandebo@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=12055

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -303 lines) Patch
M bench/BitmapRectBench.cpp View 1 2 4 chunks +19 lines, -16 lines 0 comments Download
M bench/GameBench.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M bench/Matrix44Bench.cpp View 1 2 11 chunks +49 lines, -11 lines 0 comments Download
M bench/SkBenchmark.cpp View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M bench/TileBench.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M gm/bicubicfilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bigmatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bitmapfilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bitmapmatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bleed.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M gm/blurquickreject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/drawbitmaprect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/giantbitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/ninepatchstretch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext3.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/tilemodes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkBitmap.h View 4 chunks +12 lines, -17 lines 0 comments Download
M include/core/SkBitmapDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkCanvas.h View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M include/core/SkDevice.h View 2 chunks +3 lines, -1 line 0 comments Download
M include/core/SkPaint.h View 2 chunks +3 lines, -4 lines 0 comments Download
M include/core/SkPath.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M include/core/SkPoint.h View 2 chunks +2 lines, -5 lines 0 comments Download
M include/core/SkPostConfig.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M include/core/SkPreConfig.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M include/core/SkRect.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkWriter32.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkXfermode.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkBlurDrawLooper.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkBlurMaskFilter.h View 2 chunks +2 lines, -4 lines 0 comments Download
M include/effects/SkEmbossMaskFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkPorterDuff.h View 2 chunks +1 line, -3 lines 0 comments Download
M include/effects/SkRectShaderImageFilter.h View 1 chunk +3 lines, -1 line 0 comments Download
M include/gpu/SkGpuDevice.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/utils/SkMatrix44.h View 3 chunks +5 lines, -4 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M samplecode/SampleBitmapRect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleFilter2.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M samplecode/SamplePatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleSlides.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleTextureDomain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleTiling.cpp View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleVertices.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkDrawPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBBoxHierarchyRecord.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M src/core/SkBBoxRecord.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M src/core/SkBitmapHeap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkBlitter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkBlitter_Sprite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDraw.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkMipMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkOrderedWriteBuffer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkPath.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkPicturePlayback.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkPictureRecord.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 32 chunks +39 lines, -39 lines 0 comments Download
M src/core/SkShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkSpriteBlitter_ARGB32.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkSpriteBlitter_RGB16.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBitmapAlphaThresholdShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurMask.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTestImageFilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkTransparentShader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrReducedClip.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M src/images/SkImageDecoder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/images/SkImageDecoder_libwebp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkImageEncoder_argb.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/pdf/SkPDFImage.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ports/SkImageDecoder_CG.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkCanvasStateUtils.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/debugger/SkObjectParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/views/SkWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/BitmapCopyTest.cpp View 1 2 6 chunks +6 lines, -7 lines 0 comments Download
M tests/GpuBitmapCopyTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/Matrix44Test.cpp View 1 2 25 chunks +44 lines, -34 lines 0 comments Download
M tests/PathTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/ShaderImageFilterTest.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tests/Writer32Test.cpp View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M tests/XfermodeTest.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
reed1
7 years, 1 month ago (2013-10-30 21:02:29 UTC) #1
reed1
7 years, 1 month ago (2013-10-30 21:02:40 UTC) #2
vandebo (ex-Chrome)
pdf LGTM
7 years, 1 month ago (2013-10-30 21:08:55 UTC) #3
Stephen White
effects LGTM, but Rob should take a look at the sigma stuff
7 years, 1 month ago (2013-10-30 21:36:14 UTC) #4
robertphillips
sigma stuff lgtm but see inline comments https://codereview.chromium.org/51033004/diff/1/include/effects/SkBlurDrawLooper.h File include/effects/SkBlurDrawLooper.h (right): https://codereview.chromium.org/51033004/diff/1/include/effects/SkBlurDrawLooper.h#newcode40 include/effects/SkBlurDrawLooper.h:40: why not ...
7 years, 1 month ago (2013-10-30 21:54:07 UTC) #5
reed1
https://codereview.chromium.org/51033004/diff/1/include/effects/SkBlurDrawLooper.h File include/effects/SkBlurDrawLooper.h (right): https://codereview.chromium.org/51033004/diff/1/include/effects/SkBlurDrawLooper.h#newcode40 include/effects/SkBlurDrawLooper.h:40: On 2013/10/30 21:54:08, robertphillips wrote: > why not turn ...
7 years, 1 month ago (2013-10-31 15:23:23 UTC) #6
reed1
7 years, 1 month ago (2013-10-31 16:24:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r12055 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698