Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 506103002: Rename ApplicationLoader::OnServiceError to OnApplicationError (Closed)

Created:
6 years, 3 months ago by DaveMoore
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename OnServiceError to OnApplicationError BUG= Committed: https://crrev.com/3f2fc908707451c46d322bcea57f8978ea68fdac Cr-Commit-Position: refs/heads/master@{#291951}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merge nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -60 lines) Patch
M mojo/application_manager/application_loader.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/application_manager/application_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/application_manager/application_manager_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/application_manager/background_shell_application_loader.h View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/application_manager/background_shell_application_loader.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M mojo/application_manager/background_shell_application_loader_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/view_manager/view_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/window_manager/window_manager_api_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/context.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/dbus_application_loader_linux.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/dbus_application_loader_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/dynamic_application_loader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/dynamic_application_loader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/network_application_loader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/network_application_loader.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/ui_application_loader_android.h View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/shell/ui_application_loader_android.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M mojo/shell/view_manager_loader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/view_manager_loader.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
DaveMoore
davemoore@chromium.org changed reviewers: + tim@chromium.org
6 years, 3 months ago (2014-08-26 17:14:53 UTC) #1
DaveMoore
6 years, 3 months ago (2014-08-26 17:14:53 UTC) #2
tim (not reviewing)
LGTM https://codereview.chromium.org/506103002/diff/1/mojo/application_manager/application_loader.h File mojo/application_manager/application_loader.h (right): https://codereview.chromium.org/506103002/diff/1/mojo/application_manager/application_loader.h#newcode78 mojo/application_manager/application_loader.h:78: // TODO(davemoore): Change name to OnApplicationError. nit - ...
6 years, 3 months ago (2014-08-26 17:19:25 UTC) #3
DaveMoore
Merge nits
6 years, 3 months ago (2014-08-26 17:29:22 UTC) #4
DaveMoore
The CQ bit was checked by davemoore@chromium.org
6 years, 3 months ago (2014-08-26 17:29:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/506103002/20001
6 years, 3 months ago (2014-08-26 17:31:37 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-26 18:32:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (20001) as 3b7f771437d94345cd6175ef93f3209f9863248a
6 years, 3 months ago (2014-08-26 19:02:26 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:44:26 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3f2fc908707451c46d322bcea57f8978ea68fdac
Cr-Commit-Position: refs/heads/master@{#291951}

Powered by Google App Engine
This is Rietveld 408576698