Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Side by Side Diff: mojo/shell/ui_application_loader_android.h

Issue 506103002: Rename ApplicationLoader::OnServiceError to OnApplicationError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge nits Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/shell/network_application_loader.cc ('k') | mojo/shell/ui_application_loader_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_SHELL_UI_APPLICATION_LOADER_ANDROID_H_ 5 #ifndef MOJO_SHELL_UI_APPLICATION_LOADER_ANDROID_H_
6 #define MOJO_SHELL_UI_APPLICATION_LOADER_ANDROID_H_ 6 #define MOJO_SHELL_UI_APPLICATION_LOADER_ANDROID_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "mojo/application_manager/application_loader.h" 9 #include "mojo/application_manager/application_loader.h"
10 10
(...skipping 11 matching lines...) Expand all
22 class UIApplicationLoader : public ApplicationLoader { 22 class UIApplicationLoader : public ApplicationLoader {
23 public: 23 public:
24 UIApplicationLoader(scoped_ptr<ApplicationLoader> real_loader, 24 UIApplicationLoader(scoped_ptr<ApplicationLoader> real_loader,
25 shell::Context* context); 25 shell::Context* context);
26 virtual ~UIApplicationLoader(); 26 virtual ~UIApplicationLoader();
27 27
28 // ApplicationLoader overrides: 28 // ApplicationLoader overrides:
29 virtual void Load(ApplicationManager* manager, 29 virtual void Load(ApplicationManager* manager,
30 const GURL& url, 30 const GURL& url,
31 scoped_refptr<LoadCallbacks> callbacks) OVERRIDE; 31 scoped_refptr<LoadCallbacks> callbacks) OVERRIDE;
32 virtual void OnServiceError(ApplicationManager* manager, 32 virtual void OnApplicationError(ApplicationManager* manager,
33 const GURL& url) OVERRIDE; 33 const GURL& url) OVERRIDE;
34 34
35 private: 35 private:
36 class UILoader; 36 class UILoader;
37 37
38 // These functions are exected on the background thread. They call through 38 // These functions are exected on the background thread. They call through
39 // to |background_loader_| to do the actual loading. 39 // to |background_loader_| to do the actual loading.
40 // TODO: having this code take a |manager| is fragile (as ApplicationManager 40 // TODO: having this code take a |manager| is fragile (as ApplicationManager
41 // isn't thread safe). 41 // isn't thread safe).
42 void LoadOnUIThread(ApplicationManager* manager, 42 void LoadOnUIThread(ApplicationManager* manager,
43 const GURL& url, 43 const GURL& url,
44 ScopedMessagePipeHandle* shell_handle); 44 ScopedMessagePipeHandle* shell_handle);
45 void OnServiceErrorOnUIThread(ApplicationManager* manager, const GURL& url); 45 void OnApplicationErrorOnUIThread(ApplicationManager* manager,
46 const GURL& url);
46 void ShutdownOnUIThread(); 47 void ShutdownOnUIThread();
47 48
48 scoped_ptr<ApplicationLoader> loader_; 49 scoped_ptr<ApplicationLoader> loader_;
49 shell::Context* context_; 50 shell::Context* context_;
50 51
51 // Lives on the UI thread. Trivial interface that calls through to |loader_|. 52 // Lives on the UI thread. Trivial interface that calls through to |loader_|.
52 UILoader* ui_loader_; 53 UILoader* ui_loader_;
53 54
54 DISALLOW_COPY_AND_ASSIGN(UIApplicationLoader); 55 DISALLOW_COPY_AND_ASSIGN(UIApplicationLoader);
55 }; 56 };
56 57
57 } // namespace mojo 58 } // namespace mojo
58 59
59 #endif // MOJO_SHELL_UI_APPLICATION_LOADER_ANDROID_H_ 60 #endif // MOJO_SHELL_UI_APPLICATION_LOADER_ANDROID_H_
OLDNEW
« no previous file with comments | « mojo/shell/network_application_loader.cc ('k') | mojo/shell/ui_application_loader_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698