Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Side by Side Diff: mojo/services/view_manager/view_manager_unittest.cc

Issue 506103002: Rename ApplicationLoader::OnServiceError to OnApplicationError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge nits Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/at_exit.h" 8 #include "base/at_exit.h"
9 #include "base/auto_reset.h" 9 #include "base/auto_reset.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 342 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 virtual void Load(ApplicationManager* manager, 353 virtual void Load(ApplicationManager* manager,
354 const GURL& url, 354 const GURL& url,
355 scoped_refptr<LoadCallbacks> callbacks) OVERRIDE { 355 scoped_refptr<LoadCallbacks> callbacks) OVERRIDE {
356 ScopedMessagePipeHandle shell_handle = callbacks->RegisterApplication(); 356 ScopedMessagePipeHandle shell_handle = callbacks->RegisterApplication();
357 if (!shell_handle.is_valid()) 357 if (!shell_handle.is_valid())
358 return; 358 return;
359 scoped_ptr<ApplicationImpl> app(new ApplicationImpl(this, 359 scoped_ptr<ApplicationImpl> app(new ApplicationImpl(this,
360 shell_handle.Pass())); 360 shell_handle.Pass()));
361 apps_.push_back(app.release()); 361 apps_.push_back(app.release());
362 } 362 }
363 virtual void OnServiceError(ApplicationManager* manager, 363 virtual void OnApplicationError(ApplicationManager* manager,
364 const GURL& url) OVERRIDE {} 364 const GURL& url) OVERRIDE {}
365 365
366 // ApplicationDelegate implementation: 366 // ApplicationDelegate implementation:
367 virtual bool ConfigureIncomingConnection(ApplicationConnection* connection) 367 virtual bool ConfigureIncomingConnection(ApplicationConnection* connection)
368 OVERRIDE { 368 OVERRIDE {
369 connection->AddService(this); 369 connection->AddService(this);
370 return true; 370 return true;
371 } 371 }
372 372
373 // InterfaceFactory<ViewManagerClient> implementation: 373 // InterfaceFactory<ViewManagerClient> implementation:
374 virtual void Create(ApplicationConnection* connection, 374 virtual void Create(ApplicationConnection* connection,
(...skipping 901 matching lines...) Expand 10 before | Expand all | Expand 10 after
1276 1276
1277 // TODO(sky): add coverage of test that destroys connections and ensures other 1277 // TODO(sky): add coverage of test that destroys connections and ensures other
1278 // connections get deletion notification. 1278 // connections get deletion notification.
1279 1279
1280 // TODO(sky): need to better track changes to initial connection. For example, 1280 // TODO(sky): need to better track changes to initial connection. For example,
1281 // that SetBounsdNodes/AddNode and the like don't result in messages to the 1281 // that SetBounsdNodes/AddNode and the like don't result in messages to the
1282 // originating connection. 1282 // originating connection.
1283 1283
1284 } // namespace service 1284 } // namespace service
1285 } // namespace mojo 1285 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698