Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: mojo/application_manager/background_shell_application_loader.h

Issue 506103002: Rename ApplicationLoader::OnServiceError to OnApplicationError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge nits Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_APPLICATION_MANAGER_BACKGROUND_SHELL_APPLICATION_LOADER_H_ 5 #ifndef MOJO_APPLICATION_MANAGER_BACKGROUND_SHELL_APPLICATION_LOADER_H_
6 #define MOJO_APPLICATION_MANAGER_BACKGROUND_SHELL_APPLICATION_LOADER_H_ 6 #define MOJO_APPLICATION_MANAGER_BACKGROUND_SHELL_APPLICATION_LOADER_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/synchronization/waitable_event.h" 10 #include "base/synchronization/waitable_event.h"
(...skipping 11 matching lines...) Expand all
22 public: 22 public:
23 BackgroundShellApplicationLoader(scoped_ptr<ApplicationLoader> real_loader, 23 BackgroundShellApplicationLoader(scoped_ptr<ApplicationLoader> real_loader,
24 const std::string& thread_name, 24 const std::string& thread_name,
25 base::MessageLoop::Type message_loop_type); 25 base::MessageLoop::Type message_loop_type);
26 virtual ~BackgroundShellApplicationLoader(); 26 virtual ~BackgroundShellApplicationLoader();
27 27
28 // ApplicationLoader overrides: 28 // ApplicationLoader overrides:
29 virtual void Load(ApplicationManager* manager, 29 virtual void Load(ApplicationManager* manager,
30 const GURL& url, 30 const GURL& url,
31 scoped_refptr<LoadCallbacks> callbacks) OVERRIDE; 31 scoped_refptr<LoadCallbacks> callbacks) OVERRIDE;
32 virtual void OnServiceError(ApplicationManager* manager, 32 virtual void OnApplicationError(ApplicationManager* manager,
33 const GURL& url) OVERRIDE; 33 const GURL& url) OVERRIDE;
34 34
35 private: 35 private:
36 class BackgroundLoader; 36 class BackgroundLoader;
37 37
38 // |base::DelegateSimpleThread::Delegate| method: 38 // |base::DelegateSimpleThread::Delegate| method:
39 virtual void Run() OVERRIDE; 39 virtual void Run() OVERRIDE;
40 40
41 // These functions are exected on the background thread. They call through 41 // These functions are exected on the background thread. They call through
42 // to |background_loader_| to do the actual loading. 42 // to |background_loader_| to do the actual loading.
43 // TODO: having this code take a |manager| is fragile (as ApplicationManager 43 // TODO: having this code take a |manager| is fragile (as ApplicationManager
44 // isn't thread safe). 44 // isn't thread safe).
45 void LoadOnBackgroundThread(ApplicationManager* manager, 45 void LoadOnBackgroundThread(ApplicationManager* manager,
46 const GURL& url, 46 const GURL& url,
47 ScopedMessagePipeHandle* shell_handle); 47 ScopedMessagePipeHandle* shell_handle);
48 void OnServiceErrorOnBackgroundThread(ApplicationManager* manager, 48 void OnApplicationErrorOnBackgroundThread(ApplicationManager* manager,
49 const GURL& url); 49 const GURL& url);
50 bool quit_on_shutdown_; 50 bool quit_on_shutdown_;
51 scoped_ptr<ApplicationLoader> loader_; 51 scoped_ptr<ApplicationLoader> loader_;
52 52
53 const base::MessageLoop::Type message_loop_type_; 53 const base::MessageLoop::Type message_loop_type_;
54 const std::string thread_name_; 54 const std::string thread_name_;
55 55
56 // Created on |thread_| during construction of |this|. Protected against 56 // Created on |thread_| during construction of |this|. Protected against
57 // uninitialized use by |message_loop_created_|, and protected against 57 // uninitialized use by |message_loop_created_|, and protected against
58 // use-after-free by holding a reference to the thread-safe object. Note 58 // use-after-free by holding a reference to the thread-safe object. Note
59 // that holding a reference won't hold |thread_| from exiting. 59 // that holding a reference won't hold |thread_| from exiting.
60 scoped_refptr<base::TaskRunner> task_runner_; 60 scoped_refptr<base::TaskRunner> task_runner_;
61 base::WaitableEvent message_loop_created_; 61 base::WaitableEvent message_loop_created_;
62 62
63 // Lives on |thread_|. 63 // Lives on |thread_|.
64 base::Closure quit_closure_; 64 base::Closure quit_closure_;
65 65
66 scoped_ptr<base::DelegateSimpleThread> thread_; 66 scoped_ptr<base::DelegateSimpleThread> thread_;
67 67
68 // Lives on |thread_|. Trivial interface that calls through to |loader_|. 68 // Lives on |thread_|. Trivial interface that calls through to |loader_|.
69 BackgroundLoader* background_loader_; 69 BackgroundLoader* background_loader_;
70 70
71 DISALLOW_COPY_AND_ASSIGN(BackgroundShellApplicationLoader); 71 DISALLOW_COPY_AND_ASSIGN(BackgroundShellApplicationLoader);
72 }; 72 };
73 73
74 } // namespace mojo 74 } // namespace mojo
75 75
76 #endif // MOJO_APPLICATION_MANAGER_BACKGROUND_SHELL_APPLICATION_LOADER_H_ 76 #endif // MOJO_APPLICATION_MANAGER_BACKGROUND_SHELL_APPLICATION_LOADER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698