mojo/application_manager/background_shell_application_loader.h - Issue 506103002: Rename ApplicationLoader::OnServiceError to OnApplicationError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/application_manager/background_shell_application_loader.h

Issue 506103002: Rename ApplicationLoader::OnServiceError to OnApplicationError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge nits Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/application_manager/application_manager_unittest.cc ('k') | mojo/application_manager/background_shell_application_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/application_manager/background_shell_application_loader.h

diff --git a/mojo/application_manager/background_shell_application_loader.h b/mojo/application_manager/background_shell_application_loader.h

index ee34ad89bcce7a48b4a7ef47dd22102f1ef3e132..e890903e87c58be377c176691236cabeca6ce7de 100644

--- a/mojo/application_manager/background_shell_application_loader.h

+++ b/mojo/application_manager/background_shell_application_loader.h

@@ -29,8 +29,8 @@ class MOJO_APPLICATION_MANAGER_EXPORT BackgroundShellApplicationLoader

virtual void Load(ApplicationManager* manager,

const GURL& url,

scoped_refptr<LoadCallbacks> callbacks) OVERRIDE;

- virtual void OnServiceError(ApplicationManager* manager,

- const GURL& url) OVERRIDE;

+ virtual void OnApplicationError(ApplicationManager* manager,

+ const GURL& url) OVERRIDE;

private:

class BackgroundLoader;

@@ -45,8 +45,8 @@ class MOJO_APPLICATION_MANAGER_EXPORT BackgroundShellApplicationLoader

void LoadOnBackgroundThread(ApplicationManager* manager,

const GURL& url,

ScopedMessagePipeHandle* shell_handle);

- void OnServiceErrorOnBackgroundThread(ApplicationManager* manager,

- const GURL& url);

+ void OnApplicationErrorOnBackgroundThread(ApplicationManager* manager,

+ const GURL& url);

bool quit_on_shutdown_;

scoped_ptr<ApplicationLoader> loader_;