Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 500153002: Remove reliance on linked in GL functions for assembling GLES interfaces (Closed)

Created:
6 years, 4 months ago by bsalomon
Modified:
6 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@gmcfg
Visibility:
Public.

Description

Remove reliance on linked in GL functions for assembling GLES interfaces. Make Android pull in gl2.h directly to workaround broken eglGetProcAddress for unextended GLES2 functions. Use interface assembler for angle and iOS. Committed: https://skia.googlesource.com/skia/+/a721c8167222a0b2b442a00052104b2a78ab93e5

Patch Set 1 #

Patch Set 2 : add function to get gl or gles #

Patch Set 3 : fixes #

Patch Set 4 : fix android #

Patch Set 5 : ios #

Patch Set 6 : Fix for android devices with busted eglGetProcAddress #

Patch Set 7 : cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+717 lines, -678 lines) Patch
D src/gpu/gl/GrGLAssembleGLESInterface.h View 1 chunk +0 lines, -290 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 2 2 chunks +238 lines, -0 lines 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 1 2 3 4 5 6 1 chunk +401 lines, -33 lines 1 comment Download
M src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp View 2 chunks +11 lines, -159 lines 0 comments Download
M src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp View 1 2 3 4 5 6 1 chunk +45 lines, -163 lines 0 comments Download
M src/gpu/gl/iOS/SkNativeGLContext_iOS.mm View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download
M src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/unix/GrGLCreateNativeInterface_unix.cpp View 1 2 2 chunks +1 line, -18 lines 0 comments Download
M src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
bsalomon@google.com changed reviewers: + robertphillips@google.com
6 years, 3 months ago (2014-08-26 17:00:47 UTC) #1
bsalomon
6 years, 3 months ago (2014-08-26 17:00:47 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/500153002/diff/120001/src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp File src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp (right): https://codereview.chromium.org/500153002/diff/120001/src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp#newcode16 src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp:16: SkASSERT(NULL == ctx); Yuck!
6 years, 3 months ago (2014-08-26 18:12:12 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 3 months ago (2014-08-26 18:17:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/500153002/120001
6 years, 3 months ago (2014-08-26 18:18:26 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-08-26 18:35:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #7 (120001) as a721c8167222a0b2b442a00052104b2a78ab93e5

Powered by Google App Engine
This is Rietveld 408576698