Implement rotate*() methods in DOMMatrix.

Implement rotate*() methods in DOMMatrix.

The methods multiply a rotation transformation on the current matrix
with the speicified vector or angle in degrees.

The specification:
  http://dev.w3.org/fxtf/geometry/

Intent to Implement:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V_bJNtOg0oM

BUG=388780

[zino, 2014-08-17 13:48:50]

Please take a look.

[zino, 2014-08-17 15:32:50]

I added rotateFromVector*() and rotateAxisAngle*().
Please take a look.

Thank you.

https://codereview.chromium.org/479863002/diff/20001/Source/core/dom/DOMMatri...
File Source/core/dom/DOMMatrix.cpp (right):

https://codereview.chromium.org/479863002/diff/20001/Source/core/dom/DOMMatri...
Source/core/dom/DOMMatrix.cpp:108: if (x != 0 || y != 0)
http://dev.w3.org/fxtf/geometry/#dom-dommatrix-rotateaxisangleself

The spec says that..
"If z is not 0, set is2D of the current matrix to false."

I'm not sure but it seems to be incorrect.
rotateAxisAngle(0, 0, 1, angle) is the same with rotate(angle).
So, I think the spec should be fixed.
"If x is not 0 or y is not 0, set is2D of the current matrix to false."

What do you think?

[Rik, 2014-08-22 09:17:36]

On 2014/08/17 15:32:50, zino wrote:
> I added rotateFromVector*() and rotateAxisAngle*().
> Please take a look.
> 
> Thank you.
> 
>
https://codereview.chromium.org/479863002/diff/20001/Source/core/dom/DOMMatri...
> File Source/core/dom/DOMMatrix.cpp (right):
> 
>
https://codereview.chromium.org/479863002/diff/20001/Source/core/dom/DOMMatri...
> Source/core/dom/DOMMatrix.cpp:108: if (x != 0 || y != 0)
> http://dev.w3.org/fxtf/geometry/#dom-dommatrix-rotateaxisangleself
> 
> The spec says that..
> "If z is not 0, set is2D of the current matrix to false."
> 
> I'm not sure but it seems to be incorrect.
> rotateAxisAngle(0, 0, 1, angle) is the same with rotate(angle).
> So, I think the spec should be fixed.
> "If x is not 0 or y is not 0, set is2D of the current matrix to false."
> 
> What do you think?

I believe you are right. Can you bring this up on public-fx so other UA's are
notified of this change?

lgtm

[krit, 2014-09-04 07:10:56]

lgtm

lgtm

[krit, 2014-09-04 07:10:57]

lgtm

lgtm

lgtm