Make more use of generated code in analysis server.

Make more use of generated code in analysis server.

The following generated classes are now used:
- Element
- Location
- Occurrences
- Outline
- OverriddenMember
- Override
- Position
- SearchResult
- SearchResultKind
- SourceFileEdit
- TypeHierarchyItem

Generated code is used to produce the responses to these requests:
- completion.getSuggestions
- search.findElementReferences
- search.findMemberDeclarations
- search.findMemberReferences
- search.findTopLevelDeclarations
- search.getTypeHierarchy

Generated code is used to handle these notifications in unit testing:
- analysis.navigation
- analysis.occurrences
- analysis.outline
- analysis.overrides
- search.results

In addition, we no longer bother to test the JSON conversion code on
AnalysisError, since it is code generated.

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39470

[scheglov, 2014-08-21 18:03:23]

LGTM

https://codereview.chromium.org/479683005/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/computer/computer_outline.dart (right):

https://codereview.chromium.org/479683005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/computer/computer_outline.dart:168: children:
classContents.isNotEmpty ? classContents : null);
Do we already use null instead of empty lists?
Should we do this check in toJson() instead?
This code is duplicated many times here and in other computers.

https://codereview.chromium.org/479683005/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/change.dart (right):

https://codereview.chromium.org/479683005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/change.dart:44: fileEdit = new
SourceFileEdit(file, <SourceEdit>[]);
Can we get rid of the second parameter in the constructor?
I don't think we ever use it with anything than en empty list.

https://codereview.chromium.org/479683005/diff/1/pkg/analysis_server/test/ana...
File pkg/analysis_server/test/analysis_notification_navigation_test.dart
(right):

https://codereview.chromium.org/479683005/diff/1/pkg/analysis_server/test/ana...
pkg/analysis_server/test/analysis_notification_navigation_test.dart:165: var
params = new AnalysisNavigationParams.fromNotification(notification);
Great!

[Paul Berry, 2014-08-21 20:00:44]

https://codereview.chromium.org/479683005/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/computer/computer_outline.dart (right):

https://codereview.chromium.org/479683005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/computer/computer_outline.dart:168: children:
classContents.isNotEmpty ? classContents : null);
On 2014/08/21 18:03:22, scheglov wrote:
> Do we already use null instead of empty lists?
> Should we do this check in toJson() instead?
> This code is duplicated many times here and in other computers.

Ok, I'll look into this in a future CL.

https://codereview.chromium.org/479683005/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/change.dart (right):

https://codereview.chromium.org/479683005/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/change.dart:44: fileEdit = new
SourceFileEdit(file, <SourceEdit>[]);
On 2014/08/21 18:03:22, scheglov wrote:
> Can we get rid of the second parameter in the constructor?
> I don't think we ever use it with anything than en empty list.

I think so.  I'll work on this in a separate CL.

[Paul Berry, 2014-08-21 20:04:25]

Committed patchset #1 manually as 39470 (presubmit successful).