Make more use of generated code in analysis server.

pkg/analysis_server/lib/src/services/correction/change.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.correction.change;
 
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/protocol2.dart';
 import 'package:analysis_server/src/services/json.dart';
 
 
 /**
  * A description of a single change to one or more files. 
  */
 class Change implements HasToJson {
   /**
    * A textual description of the change to be applied. 
    */
   final String message;
 
   /**
    * A list of the [FileEdit]s used to effect the change. 
    */
-  final List<FileEdit> fileEdits = <FileEdit>[];
+  final List<SourceFileEdit> fileEdits = <SourceFileEdit>[];
 
   /**
    * A list of the [LinkedEditGroup]s in the change. 
    */
   final List<LinkedEditGroup> linkedEditGroups = <LinkedEditGroup>[];
 
   /**
    * The position that should be selected after the edits have been applied.
    */
   Position selection;
 
   Change(this.message);
 
   /**
    * Adds [edit] to the [FileEdit] for the given [file].
    */
   void addEdit(String file, SourceEdit edit) {
-    FileEdit fileEdit = getFileEdit(file);
+    SourceFileEdit fileEdit = getFileEdit(file);
     if (fileEdit == null) {
-      fileEdit = new FileEdit(file);
+      fileEdit = new SourceFileEdit(file, <SourceEdit>[]);

[scheglov, 2014/08/21 18:03:22]

Can we get rid of the second parameter in the constructor?
I don't think we ever use it with anything than en empty list.

[Paul Berry, 2014/08/21 20:00:44]

I think so.  I'll work on this in a separate CL.

       addFileEdit(fileEdit);
     }
     fileEdit.add(edit);
   }
 
   /**
    * Adds the given [FileEdit].
    */
-  void addFileEdit(FileEdit edit) {
+  void addFileEdit(SourceFileEdit edit) {
     fileEdits.add(edit);
   }
 
   /**
    * Adds the given [LinkedEditGroup].
    */
   void addLinkedEditGroup(LinkedEditGroup linkedEditGroup) {
     linkedEditGroups.add(linkedEditGroup);
   }
 
   /**
    * Returns the [FileEdit] for the given [file], maybe `null`.
    */
-  FileEdit getFileEdit(String file) {
-    for (FileEdit fileEdit in fileEdits) {
+  SourceFileEdit getFileEdit(String file) {
+    for (SourceFileEdit fileEdit in fileEdits) {
       if (fileEdit.file == file) {
         return fileEdit;
       }
     }
     return null;
   }
 
   @override
   Map<String, Object> toJson() {
     Map<String, Object> json = {
       MESSAGE: message,
       EDITS: objectToJson(fileEdits),
       LINKED_EDIT_GROUPS: objectToJson(linkedEditGroups)
     };
     if (selection != null) {
       json[SELECTION] = selection.toJson();
     }
     return json;
   }
 
   @override
   String toString() =>
       'Change(message=$message, edits=$fileEdits, '
           'linkedEditGroups=$linkedEditGroups, selection=$selection)';
 }
 
 
 /**
- * A description of a set of changes to a single file.
- *
- * [Edit]s are added in the order of decreasing offset, so they are easy to
- * apply to the original file content without correcting offsets.
- */
-class FileEdit implements HasToJson {
-  /**
-   * The file to be modified.
-   */
-  final String file;
-
-  /**
-   * A list of the [Edit]s used to effect the change. 
-   */
-  final List<SourceEdit> edits = <SourceEdit>[];
-
-  FileEdit(this.file);
-
-  /**
-   * Adds the given [Edit] to the list.
-   */
-  void add(SourceEdit edit) {
-    int index = 0;
-    while (index < edits.length && edits[index].offset > edit.offset) {
-      index++;
-    }
-    edits.insert(index, edit);
-  }
-
-  /**
-   * Adds the given [Edit]s.
-   */
-  void addAll(Iterable<SourceEdit> edits) {
-    edits.forEach(add);
-  }
-
-  @override
-  Map<String, Object> toJson() {
-    return {
-      FILE: file,
-      EDITS: objectToJson(edits)
-    };
-  }
-
-  @override
-  String toString() => "FileEdit(file=$file, edits=$edits)";
-}
-
-
-/**
  * A group of linked [Position]s in multiple files that are simultaneously
  * modified - if one gets edited, all other positions in a group are edited the
  * same way. All linked positions in a group have the same content.
  */
 class LinkedEditGroup implements HasToJson {
   int length;
   final List<Position> positions = <Position>[];
   final List<LinkedEditSuggestion> suggestions = <LinkedEditSuggestion>[];
 
   void addPosition(Position position, int length) {
@@ skipping 58 matching lines @@
   static const PARAMETER = const LinkedEditSuggestionKind('PARAMETER');
   static const TYPE = const LinkedEditSuggestionKind('TYPE');
   static const VARIABLE = const LinkedEditSuggestionKind('VARIABLE');
   final String name;
 
   const LinkedEditSuggestionKind(this.name);
 
   @override
   String toString() => name;
 }
-
-
-/**
- * A position in a file.
- */
-class Position implements HasToJson {
-  final String file;
-  final int offset;
-
-  Position(this.file, this.offset);
-
-  int get hashCode {
-    int hash = file.hashCode;
-    hash = hash * 31 + offset;
-    return hash;
-  }
-
-  bool operator ==(other) {
-    if (other is Position) {
-      return other.file == file && other.offset == offset;
-    }
-    return false;
-  }
-
-  @override
-  Map<String, Object> toJson() {
-    return {
-      FILE: file,
-      OFFSET: offset
-    };
-  }
-
-  @override
-  String toString() => 'Position(file=$file, offset=$offset)';
-}