pkg/analysis_server/test/analysis_notification_overrides_test.dart - Issue 479683005: Make more use of generated code in analysis server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/analysis_notification_overrides_test.dart

Issue 479683005: Make more use of generated code in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/test/analysis_notification_navigation_test.dart ('K') | « pkg/analysis_server/test/analysis_notification_outline_test.dart ('k') | pkg/analysis_server/test/computer/element_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/analysis_notification_overrides_test.dart

diff --git a/pkg/analysis_server/test/analysis_notification_overrides_test.dart b/pkg/analysis_server/test/analysis_notification_overrides_test.dart

index fcf2bb135ce31b48c5187be13004e29253ff971e..907cce16329b1cd2663fba96566160dafaccbcf0 100644

--- a/pkg/analysis_server/test/analysis_notification_overrides_test.dart

+++ b/pkg/analysis_server/test/analysis_notification_overrides_test.dart

@@ -6,10 +6,9 @@ library test.domain.analysis.notification.overrides;

import 'dart:async';

-import 'package:analysis_server/src/computer/computer_overrides.dart';

import 'package:analysis_server/src/constants.dart';

import 'package:analysis_server/src/protocol.dart';

-import 'package:analysis_server/src/protocol2.dart' show AnalysisService;

+import 'package:analysis_server/src/protocol2.dart';

import 'package:analysis_testing/reflective_tests.dart';

import 'package:unittest/unittest.dart';

@@ -115,11 +114,9 @@ class AnalysisNotificationOverridesTest extends AbstractAnalysisTest {

void processNotification(Notification notification) {

if (notification.event == ANALYSIS_OVERRIDES) {

- String file = notification.getParameter(FILE);

- if (file == testFile) {

- List<Map<String, Object>> jsonList =

- notification.getParameter(OVERRIDES);

- overridesList = jsonList.map(Override.fromJson).toList();

+ var params = new AnalysisOverridesParams.fromNotification(notification);

+ if (params.file == testFile) {

+ overridesList = params.overrides;

}