Make more use of generated code in analysis server.

pkg/analysis_server/lib/src/protocol.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library protocol;
 
 import 'dart:collection';
 import 'dart:convert' show JsonDecoder;
 
 import 'package:analysis_server/src/services/json.dart';
@@ skipping 137 matching lines @@
   final RequestError error;
 
   /**
    * A table mapping the names of result fields to their values.  Should be
    * null if there is no result to send.
    */
   Map<String, Object> result;
 
   /**
    * Initialize a newly created instance to represent a response to a request
-   * with the given [id]. If an [error] is provided then the response will
-   * represent an error condition.
+   * with the given [id].  If [result] is provided, it will be used as the
+   * result; otherwise an empty result will be used.  If an [error] is provided
+   * then the response will represent an error condition.
    */
-  Response(this.id, [this.error]);
+  Response(this.id, {this.result, this.error});
 
   /**
    * Initialize a newly created instance to represent an error condition caused
    * by a [request] referencing a context that does not exist.
    */
   Response.contextDoesNotExist(Request request)
-    : this(request.id, new RequestError('NONEXISTENT_CONTEXT', 'Context does not exist'));
+    : this(request.id, error: new RequestError('NONEXISTENT_CONTEXT', 'Context does not exist'));
 
   /**
    * Initialize a newly created instance to represent an error condition caused
    * by a [request] that had invalid parameter.  [path] is the path to the
    * invalid parameter, in Javascript notation (e.g. "foo.bar" means that the
    * parameter "foo" contained a key "bar" whose value was the wrong type).
    * [expectation] is a description of the type of data that was expected.
    */
   Response.invalidParameter(Request request, String path, String expectation)
-      : this(request.id, new RequestError('INVALID_PARAMETER',
+      : this(request.id, error: new RequestError('INVALID_PARAMETER',
           "Expected parameter $path to $expectation"));
 
   /**
    * Initialize a newly created instance to represent an error condition caused
    * by a malformed request.
    */
   Response.invalidRequestFormat()
-    : this('', new RequestError('INVALID_REQUEST', 'Invalid request'));
+    : this('', error: new RequestError('INVALID_REQUEST', 'Invalid request'));
 
   /**
    * Initialize a newly created instance to represent an error condition caused
    * by a [request] that does not have a required parameter.
    */
   Response.missingRequiredParameter(Request request, String parameterName)
-    : this(request.id, new RequestError('MISSING_PARAMETER', 'Missing required parameter: $parameterName'));
+    : this(request.id, error: new RequestError('MISSING_PARAMETER', 'Missing required parameter: $parameterName'));
 
   /**
    * Initialize a newly created instance to represent an error condition caused
    * by a [request] that takes a set of analysis options but for which an
    * unknown analysis option was provided.
    */
   Response.unknownAnalysisOption(Request request, String optionName)
-    : this(request.id, new RequestError('UNKNOWN_ANALYSIS_OPTION', 'Unknown analysis option: "$optionName"'));
+    : this(request.id, error: new RequestError('UNKNOWN_ANALYSIS_OPTION', 'Unknown analysis option: "$optionName"'));
 
   /**
    * Initialize a newly created instance to represent an error condition caused
    * by a [request] that cannot be handled by any known handlers.
    */
   Response.unknownRequest(Request request)
-    : this(request.id, new RequestError('UNKNOWN_REQUEST', 'Unknown request'));
+    : this(request.id, error: new RequestError('UNKNOWN_REQUEST', 'Unknown request'));
 
   Response.contextAlreadyExists(Request request)
-    : this(request.id, new RequestError('CONTENT_ALREADY_EXISTS', 'Context already exists'));
+    : this(request.id, error: new RequestError('CONTENT_ALREADY_EXISTS', 'Context already exists'));
 
   Response.unsupportedFeature(String requestId, String message)
-    : this(requestId, new RequestError('UNSUPPORTED_FEATURE', message));
+    : this(requestId, error: new RequestError('UNSUPPORTED_FEATURE', message));
 
   /**
    * Initialize a newly created instance to represent an error condition caused
    * by a `analysis.setSubscriptions` [request] that includes an unknown
    * analysis service name.
    */
   Response.unknownAnalysisService(Request request, String name)
-    : this(request.id, new RequestError('UNKNOWN_ANALYSIS_SERVICE', 'Unknown analysis service: "$name"'));
+    : this(request.id, error: new RequestError('UNKNOWN_ANALYSIS_SERVICE', 'Unknown analysis service: "$name"'));
 
   /**
    * Initialize a newly created instance to represent an error condition caused
    * by a `analysis.setPriorityFiles` [request] that includes one or more files
    * that are not being analyzed.
    */
   Response.unanalyzedPriorityFiles(Request request, String fileNames)
-    : this(request.id, new RequestError('UNANALYZED_PRIORITY_FILES', "Unanalyzed files cannot be a priority: '$fileNames'"));
+    : this(request.id, error: new RequestError('UNANALYZED_PRIORITY_FILES', "Unanalyzed files cannot be a priority: '$fileNames'"));
 
   /**
    * Initialize a newly created instance to represent an error condition caused
    * by a `analysis.updateOptions` [request] that includes an unknown analysis
    * option.
    */
   Response.unknownOptionName(Request request, String optionName)
-    : this(request.id, new RequestError('UNKNOWN_OPTION_NAME', 'Unknown analysis option: "$optionName"'));
+    : this(request.id, error: new RequestError('UNKNOWN_OPTION_NAME', 'Unknown analysis option: "$optionName"'));
 
   /**
    * Initialize a newly created instance to represent an error condition caused
    * by an error during `analysis.getErrors`.
    */
   Response.getErrorsError(Request request, String message)
     : this(
         request.id,
-        new RequestError('GET_ERRORS_ERROR', 'Error during `analysis.getErrors`: $message.'));
+        error: new RequestError('GET_ERRORS_ERROR', 'Error during `analysis.getErrors`: $message.'));
 
   /**
    * Initialize a newly created instance based upon the given JSON data
    */
   factory Response.fromJson(Map<String, Object> json) {
     try {
       Object id = json[Response.ID];
       if (id is! String) {
         return null;
       }
       Object error = json[Response.ERROR];
       Object result = json[Response.RESULT];
       Response response;
       if (error is Map) {
-        response = new Response(id, new RequestError.fromJson(error));
+        response = new Response(id, error: new RequestError.fromJson(error));
       } else {
         response = new Response(id);
       }
       if (result is Map) {
         result.forEach((String key, Object value) {
           response.setResult(key, value);
         });
       }
       return response;
     } catch (exception) {
@@ skipping 322 matching lines @@
  */
 _toJson(Object value) {
   if (value is HasToJson) {
     return value.toJson();
   }
   if (value is Iterable) {
     return value.map((item) => _toJson(item)).toList();
   }
   return value;
 }