pkg/analysis_server/lib/src/domain_completion.dart - Issue 479683005: Make more use of generated code in analysis server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/domain_completion.dart

Issue 479683005: Make more use of generated code in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/computer/computer_outline.dart ('K') | « pkg/analysis_server/lib/src/computer/element.dart ('k') | pkg/analysis_server/lib/src/generated_protocol.dart » ('j') | pkg/analysis_server/lib/src/services/correction/change.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/domain_completion.dart

diff --git a/pkg/analysis_server/lib/src/domain_completion.dart b/pkg/analysis_server/lib/src/domain_completion.dart

index 258c9a4e57dca27c57c928180ce684eee37de309..137bbbfe6f7f25b8ed5ad2677f71821ca83c0358 100644

--- a/pkg/analysis_server/lib/src/domain_completion.dart

+++ b/pkg/analysis_server/lib/src/domain_completion.dart

@@ -8,7 +8,7 @@ import 'package:analysis_server/src/analysis_server.dart';

import 'package:analysis_server/src/constants.dart';

import 'package:analysis_server/src/protocol.dart';

import 'package:analysis_server/src/protocol2.dart' show

- CompletionGetSuggestionsParams;

+ CompletionGetSuggestionsParams, CompletionGetSuggestionsResult;

import 'package:analysis_server/src/services/completion/completion_manager.dart';

import 'package:analysis_server/src/services/completion/completion_suggestion.dart';

@@ -66,7 +66,8 @@ class CompletionDomainHandler implements RequestHandler {

result.last);

});

// initial response without results

- return new Response(request.id)..setResult(ID, completionId);

+ return new CompletionGetSuggestionsResult(completionId).toResponse(

+ request.id);

}

/**