Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: pkg/analysis_server/test/analysis_notification_occurrences_test.dart

Issue 479683005: Make more use of generated code in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/analysis_notification_occurrences_test.dart
diff --git a/pkg/analysis_server/test/analysis_notification_occurrences_test.dart b/pkg/analysis_server/test/analysis_notification_occurrences_test.dart
index 91a4f0b077e03787a1dada01eab0c780971c7399..725d1e6126f460dee3cf23476dd3d55cdb27bb09 100644
--- a/pkg/analysis_server/test/analysis_notification_occurrences_test.dart
+++ b/pkg/analysis_server/test/analysis_notification_occurrences_test.dart
@@ -6,11 +6,9 @@ library test.domain.analysis.notification.occurrences;
import 'dart:async';
-import 'package:analysis_server/src/computer/computer_occurrences.dart';
import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/protocol.dart';
-import 'package:analysis_server/src/protocol2.dart' show AnalysisService,
- ElementKind;
+import 'package:analysis_server/src/protocol2.dart';
import 'package:analysis_testing/reflective_tests.dart';
import 'package:unittest/unittest.dart';
@@ -88,14 +86,9 @@ class AnalysisNotificationOccurrencesTest extends AbstractAnalysisTest {
void processNotification(Notification notification) {
if (notification.event == ANALYSIS_OCCURRENCES) {
- String file = notification.getParameter(FILE);
- if (file == testFile) {
- occurrencesList = <Occurrences>[];
- List<Map<String, Object>> jsonList =
- notification.getParameter(OCCURRENCES);
- for (Map<String, Object> json in jsonList) {
- occurrencesList.add(new Occurrences.fromJson(json));
- }
+ var params = new AnalysisOccurrencesParams.fromNotification(notification);
+ if (params.file == testFile) {
+ occurrencesList = params.occurrences;
}
}
}

Powered by Google App Engine
This is Rietveld 408576698