Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 479353003: Add IsAuthenticated() method to SigninManager. (Closed)

Created:
6 years, 4 months ago by Roger Tawa OOO till Jul 10th
Modified:
6 years, 3 months ago
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, zea+watch_chromium.org, tfarina, haitaol+watch_chromium.org, dbeam+watch-options_chromium.org, pam+watch_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, Ilya Sherman, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add IsAuthenticated() method to SigninManager to check for connected profile. Make sure callers are using GetAuthenticatedUsername and GetAuthenticatedAccountId correctly. BUG=341408 TBR=bauerb@chromium.org, benwells@chromium.org, gene@chromium.org, asvitkine@chromium.org, noms@chromium.org, tim@chromium.org, sky@chromium.org Committed: https://crrev.com/f15548e894657da4ec5eca5680e45d2253d34852 Cr-Commit-Position: refs/heads/master@{#292235}

Patch Set 1 : rebased #

Patch Set 2 : Fix merge #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Total comments: 2

Patch Set 5 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -70 lines) Patch
M chrome/browser/android/bookmarks/bookmarks_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_component_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/local_discovery/privet_notifications.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/signin_status_metrics_provider.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/profiles/gaia_info_update_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_global_error.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 1 2 3 4 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/signin/signin_promo.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/supervised_user_signin_manager_wrapper.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/sync/sync_ui_util.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/search/people/people_result.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/supervised_user_import_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 2 6 chunks +9 lines, -11 lines 0 comments Download
M components/signin/core/browser/about_signin_internals.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/account_reconcilor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/signin/core/browser/signin_manager.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/signin/core/browser/signin_manager_base.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/signin/core/browser/signin_manager_base.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Roger Tawa OOO till Jul 10th
rogerta@chromium.org changed reviewers: + guohui@chromium.org
6 years, 4 months ago (2014-08-26 00:37:53 UTC) #1
Roger Tawa OOO till Jul 10th
Hi Hui, Please take a look. Thanks.
6 years, 4 months ago (2014-08-26 00:37:53 UTC) #2
Roger Tawa OOO till Jul 10th
Patchset #1 (id:120001) has been deleted
6 years, 4 months ago (2014-08-26 00:38:03 UTC) #3
Roger Tawa OOO till Jul 10th
Patchset #1 (id:140001) has been deleted
6 years, 4 months ago (2014-08-26 00:38:16 UTC) #4
Roger Tawa OOO till Jul 10th
Patchset #2 (id:180001) has been deleted
6 years, 3 months ago (2014-08-27 00:04:05 UTC) #5
Roger Tawa OOO till Jul 10th
Patchset #2 (id:200001) has been deleted
6 years, 3 months ago (2014-08-27 00:37:48 UTC) #6
guohui
lgtm https://codereview.chromium.org/479353003/diff/260001/chrome/browser/signin/signin_manager_unittest.cc File chrome/browser/signin/signin_manager_unittest.cc (right): https://codereview.chromium.org/479353003/diff/260001/chrome/browser/signin/signin_manager_unittest.cc#newcode168 chrome/browser/signin/signin_manager_unittest.cc:168: EXPECT_FALSE(!manager_->IsAuthenticated()); nits: EXPECT_TRUE(manager_>IsAuthenticated());
6 years, 3 months ago (2014-08-27 18:11:01 UTC) #7
Roger Tawa OOO till Jul 10th
Thanks Hui. https://codereview.chromium.org/479353003/diff/260001/chrome/browser/signin/signin_manager_unittest.cc File chrome/browser/signin/signin_manager_unittest.cc (right): https://codereview.chromium.org/479353003/diff/260001/chrome/browser/signin/signin_manager_unittest.cc#newcode168 chrome/browser/signin/signin_manager_unittest.cc:168: EXPECT_FALSE(!manager_->IsAuthenticated()); On 2014/08/27 18:11:01, guohui wrote: > ...
6 years, 3 months ago (2014-08-27 18:53:46 UTC) #8
Roger Tawa OOO till Jul 10th
rogerta@chromium.org changed reviewers: + asvitkine@chromium.org, bauerb@chromium.org, benwells@chromium.org, gene@chromium.org, noms@chromium.org, sky@chromium.org, tim@chromium.org
6 years, 3 months ago (2014-08-27 19:41:33 UTC) #9
Roger Tawa OOO till Jul 10th
The CQ bit was checked by rogerta@chromium.org
6 years, 3 months ago (2014-08-27 21:00:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/479353003/280001
6 years, 3 months ago (2014-08-27 21:02:10 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:280001) as 257db6f64d0ab8c19ec9a84d19069f39b706a658
6 years, 3 months ago (2014-08-27 21:51:53 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:54:28 UTC) #13
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/f15548e894657da4ec5eca5680e45d2253d34852
Cr-Commit-Position: refs/heads/master@{#292235}

Powered by Google App Engine
This is Rietveld 408576698