Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: chrome/browser/metrics/signin_status_metrics_provider.cc

Issue 479353003: Add IsAuthenticated() method to SigninManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/signin_status_metrics_provider.cc
diff --git a/chrome/browser/metrics/signin_status_metrics_provider.cc b/chrome/browser/metrics/signin_status_metrics_provider.cc
index d58dcee2b21d92d0818a625d7c70ddceb2090a73..d334df1267ee28385c00194f111e801b488ed1d7 100644
--- a/chrome/browser/metrics/signin_status_metrics_provider.cc
+++ b/chrome/browser/metrics/signin_status_metrics_provider.cc
@@ -92,7 +92,7 @@ void SigninStatusMetricsProvider::OnBrowserAdded(Browser* browser) {
if (!manager)
return;
- const bool signed_in = !manager->GetAuthenticatedUsername().empty();
+ const bool signed_in = manager->IsAuthenticated();
UpdateStatusWhenBrowserAdded(signed_in);
}
@@ -108,7 +108,7 @@ void SigninStatusMetricsProvider::SigninManagerCreated(
// profile.
if (signin_status_ == UNKNOWN_SIGNIN_STATUS) {
size_t signed_in_count =
- manager->GetAuthenticatedUsername().empty() ? 0 : 1;
+ manager->IsAuthenticated() ? 1 : 0;
UpdateInitialSigninStatus(1, signed_in_count);
}
}
@@ -210,7 +210,7 @@ void SigninStatusMetricsProvider::ComputeCurrentSigninStatus() {
opened_profiles_count++;
SigninManager* manager = SigninManagerFactory::GetForProfile(
profile_list[i]->GetOriginalProfile());
- if (manager && !manager->GetAuthenticatedUsername().empty())
+ if (manager && manager->IsAuthenticated())
signed_in_profiles_count++;
}
UpdateInitialSigninStatus(opened_profiles_count, signed_in_profiles_count);

Powered by Google App Engine
This is Rietveld 408576698