chrome/browser/sync/profile_sync_service.cc - Issue 479353003: Add IsAuthenticated() method to SigninManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service.cc

Issue 479353003: Add IsAuthenticated() method to SigninManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/profile_sync_service.cc

diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc

index 52aa05f64ab6a4bec91ebe827e68aa21507b1487..6bbf3813f7fca1ef00eba9863cc8cc8414e6d91f 100644

--- a/chrome/browser/sync/profile_sync_service.cc

+++ b/chrome/browser/sync/profile_sync_service.cc

@@ -2541,10 +2541,7 @@ SigninManagerBase* ProfileSyncService::signin() const {

void ProfileSyncService::UnsuppressAndStart() {

DCHECK(profile_);

sync_prefs_.SetStartSuppressed(false);

- // Set username in SigninManager, as SigninManager::OnGetUserInfoSuccess

- // is never called for some clients.

- if (signin_.get() &&

- signin_->GetOriginal()->GetAuthenticatedUsername().empty()) {

+ if (signin_.get() && !signin_->GetOriginal()->IsAuthenticated()) {

signin_->GetOriginal()->SetAuthenticatedUsername(

profile_->GetPrefs()->GetString(prefs::kGoogleServicesUsername));

}