components/signin/core/browser/about_signin_internals.cc - Issue 479353003: Add IsAuthenticated() method to SigninManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/about_signin_internals.cc

Issue 479353003: Add IsAuthenticated() method to SigninManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/core/browser/about_signin_internals.cc

diff --git a/components/signin/core/browser/about_signin_internals.cc b/components/signin/core/browser/about_signin_internals.cc

index 01f578220907893bf0c47fd3f2c2f7cdd4c73419..86db713f65c99ddc0ba2b68d831a660b64e19033 100644

--- a/components/signin/core/browser/about_signin_internals.cc

+++ b/components/signin/core/browser/about_signin_internals.cc

@@ -165,7 +165,7 @@ void AboutSigninInternals::RefreshSigninPrefs() {

// (as seen in the AboutSigninInternalsFactory) the SigninManager can have

// the AuthenticatedUsername set before AboutSigninInternals can observe it.

// For that scenario, read the AuthenticatedUsername if it exists.

- if (!signin_manager_->GetAuthenticatedUsername().empty()) {

+ if (signin_manager_->IsAuthenticated()) {

signin_status_.untimed_signin_fields[USERNAME] =

signin_manager_->GetAuthenticatedUsername();

}