chrome/browser/signin/signin_global_error.cc - Issue 479353003: Add IsAuthenticated() method to SigninManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_global_error.cc

Issue 479353003: Add IsAuthenticated() method to SigninManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/signin/signin_global_error.cc

diff --git a/chrome/browser/signin/signin_global_error.cc b/chrome/browser/signin/signin_global_error.cc

index 5131e09e661c22162d732f243e6cd40f84d0341a..8fabe932b181cd7faf3744464377105b742345dc 100644

--- a/chrome/browser/signin/signin_global_error.cc

+++ b/chrome/browser/signin/signin_global_error.cc

@@ -124,11 +124,8 @@ std::vector<base::string16> SigninGlobalError::GetBubbleViewMessages() {

// If the user isn't signed in, no need to display an error bubble.

SigninManagerBase* signin_manager =

SigninManagerFactory::GetForProfileIfExists(profile_);

- if (signin_manager) {

- std::string username = signin_manager->GetAuthenticatedUsername();

- if (username.empty())

+ if (signin_manager && !signin_manager->IsAuthenticated())

return messages;

- }

if (!error_controller_->HasError())

return messages;