chrome/browser/ui/webui/options/browser_options_handler.cc - Issue 479353003: Add IsAuthenticated() method to SigninManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 479353003: Add IsAuthenticated() method to SigninManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/browser_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc

index 1d41103b095254c60b7d702939d4d816e45b7cba..ff649cd52deed6a22d9b4e0669fe35f89e7c7667 100644

--- a/chrome/browser/ui/webui/options/browser_options_handler.cc

+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc

@@ -1389,8 +1389,7 @@ BrowserOptionsHandler::GetSyncStateDictionary() {

sync_status->SetBoolean("hasError", status_has_error);

sync_status->SetBoolean("managed", service && service->IsManaged());

- sync_status->SetBoolean("signedIn",

- !signin->GetAuthenticatedUsername().empty());

+ sync_status->SetBoolean("signedIn", signin->IsAuthenticated());

sync_status->SetBoolean("hasUnrecoverableError",

service && service->HasUnrecoverableError());