Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 477273003: Revert 290030 "[Password Manager] Setup experiment to restrict a..." (Closed)

Created:
6 years, 4 months ago by miu
Modified:
6 years, 4 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 290030 "[Password Manager] Setup experiment to restrict a..." This caused a tree closure due to unit_tests failure: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/47244 > [Password Manager] Setup experiment to restrict autofilling of sync credential > > By default there is no change in behavior, but autofilling can now be disabled > for the sync credential entirely or just disabled for reauth pages that support > transactional reauth. > > Note that this also changes GetSyncUsername() to not return the username if > password sync is disabled if it is possible to determine. This makes GetSyncUsername() a little inconsistent depending on the state of sync setup, but it's important to be as specific as possible when disabling autofilling, since it's a > usability hit. > > BUG=386692 > R=isherman@chromium.org > > Review URL: https://codereview.chromium.org/451853003 TBR=gcasto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290045

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -297 lines) Patch
M trunk/src/chrome/app/generated_resources.grd View 2 chunks +0 lines, -16 lines 0 comments Download
M trunk/src/chrome/browser/about_flags.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M trunk/src/chrome/browser/password_manager/chrome_password_manager_client.h View 4 chunks +1 line, -27 lines 0 comments Download
M trunk/src/chrome/browser/password_manager/chrome_password_manager_client.cc View 7 chunks +2 lines, -84 lines 0 comments Download
M trunk/src/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 2 chunks +0 lines, -74 lines 0 comments Download
M trunk/src/chrome/browser/password_manager/sync_metrics.h View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/password_manager/sync_metrics.cc View 1 chunk +1 line, -10 lines 0 comments Download
M trunk/src/components/password_manager/core/browser/password_form_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/password_manager/core/browser/password_form_manager.cc View 4 chunks +2 lines, -8 lines 0 comments Download
M trunk/src/components/password_manager/core/browser/password_form_manager_unittest.cc View 4 chunks +1 line, -18 lines 0 comments Download
M trunk/src/components/password_manager/core/browser/password_manager_client.h View 1 chunk +0 lines, -8 lines 0 comments Download
M trunk/src/components/password_manager/core/browser/stub_password_manager_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/components/password_manager/core/browser/stub_password_manager_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/components/password_manager/core/common/password_manager_switches.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/components/password_manager/core/common/password_manager_switches.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
miu
6 years, 4 months ago (2014-08-15 23:23:07 UTC) #1
miu
Committed patchset #1 manually as r290045.
6 years, 4 months ago (2014-08-15 23:23:20 UTC) #2
miu
6 years, 4 months ago (2014-08-15 23:25:23 UTC) #3
FYI--Started failing on all platforms (e.g. multiple Mac test bots).
 Please use the CQ next time.

-Yuri



On Fri, Aug 15, 2014 at 4:23 PM, <miu@chromium.org> wrote:

> Committed patchset #1 manually as r290045.
>
> https://codereview.chromium.org/477273003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698