Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: trunk/src/chrome/browser/password_manager/sync_metrics.h

Issue 477273003: Revert 290030 "[Password Manager] Setup experiment to restrict a..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/password_manager/sync_metrics.h
===================================================================
--- trunk/src/chrome/browser/password_manager/sync_metrics.h (revision 290044)
+++ trunk/src/chrome/browser/password_manager/sync_metrics.h (working copy)
@@ -12,9 +12,9 @@
namespace password_manager_sync_metrics {
// Returns the sync username for |profile|. Returns an empty string if the
-// |profile| isn't syncing. This function tries to return an empty string if
-// the user isn't syncing passwords, but it is not always possibly to determine
-// since this code can be called during sync setup (http://crbug.com/393626).
+// |profile| isn't syncing. It would be preferable to only return the username
+// if the user is syncing passwords, but that is not currently possible since
+// this function can be called during sync setup (http://crbug.com/393626).
std::string GetSyncUsername(Profile* profile);
// Returns true if |username| and |origin| correspond to the account which is

Powered by Google App Engine
This is Rietveld 408576698