Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: trunk/src/chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 477273003: Revert 290030 "[Password Manager] Setup experiment to restrict a..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/password_manager/chrome_password_manager_client.cc
===================================================================
--- trunk/src/chrome/browser/password_manager/chrome_password_manager_client.cc (revision 290044)
+++ trunk/src/chrome/browser/password_manager/chrome_password_manager_client.cc (working copy)
@@ -8,7 +8,6 @@
#include "base/command_line.h"
#include "base/memory/singleton.h"
#include "base/metrics/histogram.h"
-#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/password_manager/password_manager_util.h"
#include "chrome/browser/password_manager/password_store_factory.h"
#include "chrome/browser/password_manager/save_password_infobar_delegate.h"
@@ -34,8 +33,6 @@
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
-#include "google_apis/gaia/gaia_urls.h"
-#include "net/base/url_util.h"
#if defined(OS_ANDROID)
#include "chrome/browser/android/password_authentication_manager.h"
@@ -66,14 +63,11 @@
driver_(web_contents, this, autofill_client),
observer_(NULL),
weak_factory_(this),
- can_use_log_router_(false),
- autofill_sync_state_(ALLOW_SYNC_CREDENTIALS),
- sync_credential_was_filtered_(false) {
+ can_use_log_router_(false) {
PasswordManagerInternalsService* service =
PasswordManagerInternalsServiceFactory::GetForBrowserContext(profile_);
if (service)
can_use_log_router_ = service->RegisterClient(this);
- SetUpAutofillSyncState();
}
ChromePasswordManagerClient::~ChromePasswordManagerClient() {
@@ -85,7 +79,7 @@
bool ChromePasswordManagerClient::IsAutomaticPasswordSavingEnabled() const {
return CommandLine::ForCurrentProcess()->HasSwitch(
- password_manager::switches::kEnableAutomaticPasswordSaving) &&
+ password_manager::switches::kEnableAutomaticPasswordSaving) &&
chrome::VersionInfo::GetChannel() ==
chrome::VersionInfo::CHANNEL_UNKNOWN;
}
@@ -108,38 +102,12 @@
return entry->GetURL().host() != chrome::kChromeUIChromeSigninHost;
}
-bool ChromePasswordManagerClient::ShouldFilterAutofillResult(
- const autofill::PasswordForm& form) {
- if (!IsSyncAccountCredential(base::UTF16ToUTF8(form.username_value),
- form.signon_realm))
- return false;
-
- if (autofill_sync_state_ == DISALLOW_SYNC_CREDENTIALS) {
- sync_credential_was_filtered_ = true;
- return true;
- }
-
- if (autofill_sync_state_ == DISALLOW_SYNC_CREDENTIALS_FOR_REAUTH &&
- LastLoadWasTransactionalReauthPage()) {
- sync_credential_was_filtered_ = true;
- return true;
- }
-
- return false;
-}
-
bool ChromePasswordManagerClient::IsSyncAccountCredential(
const std::string& username, const std::string& origin) const {
return password_manager_sync_metrics::IsSyncAccountCredential(
profile_, username, origin);
}
-void ChromePasswordManagerClient::AutofillResultsComputed() {
- UMA_HISTOGRAM_BOOLEAN("PasswordManager.SyncCredentialFiltered",
- sync_credential_was_filtered_);
- sync_credential_was_filtered_ = false;
-}
-
void ChromePasswordManagerClient::PromptUserToSavePassword(
scoped_ptr<password_manager::PasswordFormManager> form_to_save) {
if (IsTheHotNewBubbleUIEnabled()) {
@@ -385,24 +353,6 @@
driver_.FillPasswordForm(*data);
}
-bool ChromePasswordManagerClient::LastLoadWasTransactionalReauthPage() const {
- DCHECK(web_contents());
- content::NavigationEntry* entry =
- web_contents()->GetController().GetLastCommittedEntry();
- if (!entry)
- return false;
-
- if (entry->GetURL().GetOrigin() !=
- GaiaUrls::GetInstance()->gaia_url().GetOrigin())
- return false;
-
- // "rart" is the transactional reauth paramter.
- std::string ignored_value;
- return net::GetValueForKeyInQuery(entry->GetURL(),
- "rart",
- &ignored_value);
-}
-
bool ChromePasswordManagerClient::IsTheHotNewBubbleUIEnabled() {
#if !defined(USE_AURA)
return false;
@@ -436,35 +386,3 @@
base::FieldTrialList::FindFullName("PasswordManagerStateForSyncSignin");
return group_name != "Disabled";
}
-
-void ChromePasswordManagerClient::SetUpAutofillSyncState() {
- std::string group_name =
- base::FieldTrialList::FindFullName("AutofillSyncCredential");
-
- CommandLine* command_line = CommandLine::ForCurrentProcess();
- if (command_line->HasSwitch(
- password_manager::switches::kAllowAutofillSyncCredential)) {
- autofill_sync_state_ = ALLOW_SYNC_CREDENTIALS;
- return;
- }
- if (command_line->HasSwitch(
- password_manager::switches::
- kDisallowAutofillSyncCredentialForReauth)) {
- autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS_FOR_REAUTH;
- return;
- }
- if (command_line->HasSwitch(
- password_manager::switches::kDisallowAutofillSyncCredential)) {
- autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS;
- return;
- }
-
- if (group_name == "DisallowSyncCredentialsForReauth") {
- autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS_FOR_REAUTH;
- } else if (group_name == "DisallowSyncCredentials") {
- autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS;
- } else {
- // Allow by default.
- autofill_sync_state_ = ALLOW_SYNC_CREDENTIALS;
- }
-}

Powered by Google App Engine
This is Rietveld 408576698