Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: trunk/src/chrome/browser/password_manager/chrome_password_manager_client.h

Issue 477273003: Revert 290030 "[Password Manager] Setup experiment to restrict a..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/password_manager/chrome_password_manager_client.h
===================================================================
--- trunk/src/chrome/browser/password_manager/chrome_password_manager_client.h (revision 290044)
+++ trunk/src/chrome/browser/password_manager/chrome_password_manager_client.h (working copy)
@@ -40,11 +40,8 @@
// PasswordManagerClient implementation.
virtual bool IsAutomaticPasswordSavingEnabled() const OVERRIDE;
virtual bool IsPasswordManagerEnabledForCurrentPage() const OVERRIDE;
- virtual bool ShouldFilterAutofillResult(
- const autofill::PasswordForm& form) OVERRIDE;
virtual bool IsSyncAccountCredential(
const std::string& username, const std::string& origin) const OVERRIDE;
- virtual void AutofillResultsComputed() OVERRIDE;
virtual void PromptUserToSavePassword(
scoped_ptr<password_manager::PasswordFormManager> form_to_save) OVERRIDE;
virtual void AutomaticPasswordSave(
@@ -93,18 +90,9 @@
// Returns true if the password manager should be enabled during sync signin.
static bool EnabledForSyncSignin();
- protected:
- // Callable for tests.
+ private:
ChromePasswordManagerClient(content::WebContents* web_contents,
autofill::AutofillClient* autofill_client);
-
- private:
- enum AutofillForSyncCredentialsState {
- ALLOW_SYNC_CREDENTIALS,
- DISALLOW_SYNC_CREDENTIALS_FOR_REAUTH,
- DISALLOW_SYNC_CREDENTIALS,
- };
-
friend class content::WebContentsUserData<ChromePasswordManagerClient>;
// content::WebContentsObserver overrides.
@@ -134,13 +122,6 @@
// |can_use_log_router_|.
void NotifyRendererOfLoggingAvailability();
- // Returns true if the last loaded page was for transactional re-auth on a
- // Google property.
- bool LastLoadWasTransactionalReauthPage() const;
-
- // Sets |autofill_state_| based on experiment and flag values.
- void SetUpAutofillSyncState();
-
Profile* const profile_;
password_manager::ContentPasswordManagerDriver driver_;
@@ -158,13 +139,6 @@
// True if |this| is registered with some LogRouter which can accept logs.
bool can_use_log_router_;
- // How to handle the sync credential in ShouldFilterAutofillResult().
- AutofillForSyncCredentialsState autofill_sync_state_;
-
- // If the sync credential was filtered during autofill. Used for statistics
- // reporting.
- bool sync_credential_was_filtered_;
-
DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
};
« no previous file with comments | « trunk/src/chrome/browser/about_flags.cc ('k') | trunk/src/chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698