Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: trunk/src/components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 477273003: Revert 290030 "[Password Manager] Setup experiment to restrict a..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/components/password_manager/core/browser/password_form_manager_unittest.cc
===================================================================
--- trunk/src/components/password_manager/core/browser/password_form_manager_unittest.cc (revision 290044)
+++ trunk/src/components/password_manager/core/browser/password_form_manager_unittest.cc (working copy)
@@ -60,13 +60,6 @@
true);
}
- virtual bool ShouldFilterAutofillResult(
- const autofill::PasswordForm& form) OVERRIDE {
- if (form == form_to_filter_)
- return true;
- return false;
- }
-
virtual void PromptUserToSavePassword(
scoped_ptr<PasswordFormManager> form_to_save) OVERRIDE {}
virtual PrefService* GetPrefs() OVERRIDE { return &prefs_; }
@@ -77,15 +70,9 @@
driver_.FillPasswordForm(*fill_data.get());
}
- void SetFormToFilter(const autofill::PasswordForm& form) {
- form_to_filter_ = form;
- }
-
MockPasswordManagerDriver* GetMockDriver() { return &driver_; }
private:
- autofill::PasswordForm form_to_filter_;
-
TestingPrefServiceSimple prefs_;
PasswordStore* password_store_;
MockPasswordManagerDriver driver_;
@@ -190,7 +177,7 @@
}
bool IgnoredResult(PasswordFormManager* p, PasswordForm* form) {
- return p->ShouldIgnoreResult(*form);
+ return p->IgnoreResult(*form);
}
PasswordForm* observed_form() { return &observed_form_; }
@@ -440,10 +427,6 @@
saved_match()->action = GURL("http://www.google.com/b/Login");
saved_match()->origin = GURL("http://www.google.com/foo");
EXPECT_FALSE(IgnoredResult(&manager, saved_match()));
-
- // Results should be ignored if the client requests it.
- client()->SetFormToFilter(*saved_match());
- EXPECT_TRUE(IgnoredResult(&manager, saved_match()));
}
TEST_F(PasswordFormManagerTest, TestEmptyAction) {

Powered by Google App Engine
This is Rietveld 408576698