Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: trunk/src/components/password_manager/core/browser/password_form_manager.cc

Issue 477273003: Revert 290030 "[Password Manager] Setup experiment to restrict a..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/components/password_manager/core/browser/password_form_manager.cc
===================================================================
--- trunk/src/components/password_manager/core/browser/password_form_manager.cc (revision 290044)
+++ trunk/src/components/password_manager/core/browser/password_form_manager.cc (working copy)
@@ -379,7 +379,7 @@
// These credentials will be in the final result regardless of score.
std::vector<PasswordForm> credentials_to_keep;
for (size_t i = 0; i < logins_result.size(); i++) {
- if (ShouldIgnoreResult(*logins_result[i])) {
+ if (IgnoreResult(*logins_result[i])) {
delete logins_result[i];
continue;
}
@@ -439,8 +439,6 @@
// We're done matching now.
state_ = POST_MATCHING_PHASE;
- client_->AutofillResultsComputed();
-
if (best_score <= 0) {
return;
}
@@ -509,7 +507,7 @@
OnRequestDone(results);
}
-bool PasswordFormManager::ShouldIgnoreResult(const PasswordForm& form) const {
+bool PasswordFormManager::IgnoreResult(const PasswordForm& form) const {
// Do not autofill on sign-up or change password forms (until we have some
// working change password functionality).
if (!observed_form_.new_password_element.empty())
@@ -517,10 +515,6 @@
// Don't match an invalid SSL form with one saved under secure circumstances.
if (form.ssl_valid && !observed_form_.ssl_valid)
return true;
-
- if (client_->ShouldFilterAutofillResult(form))
- return true;
-
return false;
}

Powered by Google App Engine
This is Rietveld 408576698