Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 469003006: Remove --disable-core-animation flag (Closed)

Created:
6 years, 4 months ago by ccameron
Modified:
6 years, 4 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@erikchen_patch
Project:
chromium
Visibility:
Public.

Description

Remove --disable-core-animation flag This doesn't do anything effective anymore. BUG=245900 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289998

Patch Set 1 #

Total comments: 5

Patch Set 2 : UI changes too (oops) #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -336 lines) Patch
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/fast_resize_view.h View 2 chunks +3 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/fast_resize_view.mm View 1 2 7 chunks +10 lines, -71 lines 0 comments Download
D chrome/browser/ui/cocoa/fast_resize_view_unittest.mm View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_view.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_mode_controller.mm View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/nsview_additions.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/nsview_additions.mm View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_icon_controller.mm View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm View 3 chunks +5 lines, -12 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/cocoa/underlay_opengl_hosting_window.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/underlay_opengl_hosting_window.mm View 2 chunks +4 lines, -134 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/ui_base_switches.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ccameron
Long overdue... sky: this will need a re-resolve again https://codereview.chromium.org/464063005/ lands.
6 years, 4 months ago (2014-08-14 19:16:07 UTC) #1
Avi (use Gerrit)
https://codereview.chromium.org/469003006/diff/1/chrome/browser/ui/cocoa/nsview_additions.mm File chrome/browser/ui/cocoa/nsview_additions.mm (left): https://codereview.chromium.org/469003006/diff/1/chrome/browser/ui/cocoa/nsview_additions.mm#oldcode82 chrome/browser/ui/cocoa/nsview_additions.mm:82: return; Do we ever call setWantsLayer:NO? I'm hoping we ...
6 years, 4 months ago (2014-08-14 19:23:41 UTC) #2
Avi (use Gerrit)
So a search seems to find nowhere where we called cr_setWantsLayer:NO, so LGTM.
6 years, 4 months ago (2014-08-14 19:30:34 UTC) #3
ccameron
Thanks! https://codereview.chromium.org/469003006/diff/1/chrome/browser/ui/cocoa/nsview_additions.mm File chrome/browser/ui/cocoa/nsview_additions.mm (left): https://codereview.chromium.org/469003006/diff/1/chrome/browser/ui/cocoa/nsview_additions.mm#oldcode82 chrome/browser/ui/cocoa/nsview_additions.mm:82: return; On 2014/08/14 19:23:40, Avi wrote: > Do ...
6 years, 4 months ago (2014-08-14 19:34:39 UTC) #4
Avi (use Gerrit)
https://codereview.chromium.org/469003006/diff/1/ui/base/cocoa/underlay_opengl_hosting_window.h File ui/base/cocoa/underlay_opengl_hosting_window.h (right): https://codereview.chromium.org/469003006/diff/1/ui/base/cocoa/underlay_opengl_hosting_window.h#newcode14 ui/base/cocoa/underlay_opengl_hosting_window.h:14: // contains common asserts. For now, we can leave ...
6 years, 4 months ago (2014-08-14 19:57:27 UTC) #5
ccameron
Adding sky@ for ui/base OWNER bits.
6 years, 4 months ago (2014-08-15 17:36:56 UTC) #6
sky
LGTM
6 years, 4 months ago (2014-08-15 19:09:09 UTC) #7
ccameron
Thanks!
6 years, 4 months ago (2014-08-15 19:14:45 UTC) #8
ccameron
The CQ bit was checked by ccameron@chromium.org
6 years, 4 months ago (2014-08-15 19:14:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/469003006/40001
6 years, 4 months ago (2014-08-15 19:18:31 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 20:26:31 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 289998

Powered by Google App Engine
This is Rietveld 408576698