Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: chrome/browser/ui/cocoa/fast_resize_view.mm

Issue 469003006: Remove --disable-core-animation flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@erikchen_patch
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/fast_resize_view.h ('k') | chrome/browser/ui/cocoa/fast_resize_view_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/fast_resize_view.mm
diff --git a/chrome/browser/ui/cocoa/fast_resize_view.mm b/chrome/browser/ui/cocoa/fast_resize_view.mm
index 848d356540a9b42c2e3e8eb3d971dc3c20b18701..fdbc3e80e90253b1f1d1fac591b9c29f2265f5e4 100644
--- a/chrome/browser/ui/cocoa/fast_resize_view.mm
+++ b/chrome/browser/ui/cocoa/fast_resize_view.mm
@@ -7,10 +7,8 @@
#import <Cocoa/Cocoa.h>
#include "base/logging.h"
-#include "base/command_line.h"
#include "base/mac/scoped_nsobject.h"
#include "ui/base/cocoa/animation_utils.h"
-#include "ui/base/ui_base_switches.h"
namespace {
@@ -20,17 +18,12 @@ const CGFloat kRoundedCornerRadius = 4;
} // namespace
@interface FastResizeView (PrivateMethods)
-// Lays out this views subviews. If fast resize mode is on, does not resize any
-// subviews and instead pegs them to the top left. If fast resize mode is off,
-// sets the subviews' frame to be equal to this view's bounds.
-- (void)layoutSubviews;
-
// Creates a path whose bottom two corners are rounded.
// Caller takes ownership of the path.
- (CGPathRef)createRoundedBottomCornersPath:(NSSize)size;
// Updates the path of the layer mask to reflect the current value of
-// roundedBottomCorners_ and fastResizeMode_.
+// roundedBottomCorners_.
- (void)updateLayerMask;
@end
@@ -38,17 +31,14 @@ const CGFloat kRoundedCornerRadius = 4;
- (id)initWithFrame:(NSRect)frameRect {
if ((self = [super initWithFrame:frameRect])) {
- if (!CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kDisableCoreAnimation)) {
- ScopedCAActionDisabler disabler;
- base::scoped_nsobject<CALayer> layer([[CALayer alloc] init]);
- [layer setBackgroundColor:CGColorGetConstantColor(kCGColorWhite)];
- [self setLayer:layer];
- [self setWantsLayer:YES];
-
- roundedBottomCorners_ = YES;
- [self updateLayerMask];
- }
+ ScopedCAActionDisabler disabler;
+ base::scoped_nsobject<CALayer> layer([[CALayer alloc] init]);
+ [layer setBackgroundColor:CGColorGetConstantColor(kCGColorWhite)];
+ [self setLayer:layer];
+ [self setWantsLayer:YES];
+
+ roundedBottomCorners_ = YES;
+ [self updateLayerMask];
}
return self;
}
@@ -57,20 +47,6 @@ const CGFloat kRoundedCornerRadius = 4;
return YES;
}
-- (void)setFastResizeMode:(BOOL)fastResizeMode {
- if (fastResizeMode_ == fastResizeMode)
- return;
-
- fastResizeMode_ = fastResizeMode;
- [self updateLayerMask];
-
- // Force a relayout when coming out of fast resize mode.
- if (!fastResizeMode_)
- [self layoutSubviews];
-
- [self setNeedsDisplay:YES];
-}
-
- (void)setRoundedBottomCorners:(BOOL)roundedBottomCorners {
if (roundedBottomCorners == roundedBottomCorners_)
return;
@@ -79,21 +55,6 @@ const CGFloat kRoundedCornerRadius = 4;
[self updateLayerMask];
}
-- (void)resizeSubviewsWithOldSize:(NSSize)oldSize {
- [self layoutSubviews];
-}
-
-- (void)drawRect:(NSRect)dirtyRect {
- // If we are in fast resize mode, our subviews may not completely cover our
- // bounds, so we fill with white. If we are not in fast resize mode, we do
- // not need to draw anything.
- if (!fastResizeMode_)
- return;
-
- [[NSColor whiteColor] set];
- NSRectFill(dirtyRect);
-}
-
// Every time the frame's size changes, the layer mask needs to be updated.
- (void)setFrameSize:(NSSize)newSize {
[super setFrameSize:newSize];
@@ -104,28 +65,6 @@ const CGFloat kRoundedCornerRadius = 4;
@implementation FastResizeView (PrivateMethods)
-- (void)layoutSubviews {
- // There should never be more than one subview. There can be zero, if we are
- // in the process of switching tabs or closing the window. In those cases, no
- // layout is needed.
- NSArray* subviews = [self subviews];
- DCHECK([subviews count] <= 1);
- if ([subviews count] < 1)
- return;
-
- NSView* subview = [subviews objectAtIndex:0];
- NSRect bounds = [self bounds];
-
- if (fastResizeMode_) {
- NSRect frame = [subview frame];
- frame.origin.x = 0;
- frame.origin.y = NSHeight(bounds) - NSHeight(frame);
- [subview setFrame:frame];
- } else {
- [subview setFrame:bounds];
- }
-}
-
- (CGPathRef)createRoundedBottomCornersPath:(NSSize)size {
CGMutablePathRef path = CGPathCreateMutable();
CGFloat width = size.width;
@@ -165,7 +104,7 @@ const CGFloat kRoundedCornerRadius = 4;
}
- (void)updateLayerMask {
- if (fastResizeMode_ || !roundedBottomCorners_) {
+ if (!roundedBottomCorners_) {
[self layer].mask = nil;
layerMask_ = nil;
return;
« no previous file with comments | « chrome/browser/ui/cocoa/fast_resize_view.h ('k') | chrome/browser/ui/cocoa/fast_resize_view_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698