Enables permission bubbles to remain visible during fulscreen on Mac.

Enables permission bubbles to remain visible during fullscreen on Mac.

Adds IsVisible() function to PermissionBubbleView so that the browser window
knows if it is currently being shown.  It's added to the base class, rather than
just the cocoa implementation, because similar functionality will likely be
used for views in the future.

Adds alwaysShowDropdown property to the PresentationModeController.
When set to YES, it disables hiding of the dropdown - toolbar and tab strip.

Also adds a hack to ensure the UI is drawn correctly when entering fullscreen
mode.  Specifically, for the duration of the animation, the top-level view for
the browser window has setWantsLayer set to YES.  Without this, tabStripView
is not rendered into the destination frame for the animation.  (It is a sibling of
the content view, not a subview, and I believe that the non-layer-based
render path bypasses it when the animation begins.)  I could not come up
with any other mechanism to fix this, and without it, fullscreen looks quite
bad - the toolbar displays properly, but the tab strip is missing.

BUG=384260
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284438

[leng, 2014-07-11 20:50:54]

@gbillock - permission bubble changes
@rsesek - you've been reviewing other fullscreen CLs, so will have context

[Robert Sesek, 2014-07-14 14:13:32]

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:639: -
(void)permissionBubbleWindowWillClose:(NSNotification*)notification {
This needs to be declared in the .h

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/presentation_mode_controller.h (right):

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/presentation_mode_controller.h:45: BOOL
alwaysShowDropdown_;
Have you looked at -[BrowserWindowController
lockBarVisibilityForOwner:withAnimation:delay:] instead?

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h (right):

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h:39: NSPoint
AnchorPoint();
naming: GetAnchorPoint()

[leng, 2014-07-14 18:17:24]

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:639: -
(void)permissionBubbleWindowWillClose:(NSNotification*)notification {
On 2014/07/14 14:13:32, rsesek wrote:
> This needs to be declared in the .h

Done.

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/presentation_mode_controller.h (right):

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/presentation_mode_controller.h:45: BOOL
alwaysShowDropdown_;
On 2014/07/14 14:13:32, rsesek wrote:
> Have you looked at -[BrowserWindowController
> lockBarVisibilityForOwner:withAnimation:delay:] instead?

I did, early on during my investigation.  I thought it just didn't work.  It
turns out, there was a rogue call to -ensureOverlayHiddenWithAnimation:...  I've
now fixed that.  It still won't work if there are other rogue calls to either of
the -ensureOverlay* functions, but at least the locking mechanism allows
multiple locks.

alwaysShowDropDown_ is removed, though what would you think about adding a flag
set by the browserWindowController's lock methods that this class could DCHECK? 
It might catch other rogue calls to -ensureOverlay*.

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h (right):

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h:39: NSPoint
AnchorPoint();
On 2014/07/14 14:13:32, rsesek wrote:
> naming: GetAnchorPoint()

Done.

[Robert Sesek, 2014-07-14 20:22:31]

LGTM

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/presentation_mode_controller.h (right):

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/presentation_mode_controller.h:45: BOOL
alwaysShowDropdown_;
On 2014/07/14 18:17:24, leng wrote:
> On 2014/07/14 14:13:32, rsesek wrote:
> > Have you looked at -[BrowserWindowController
> > lockBarVisibilityForOwner:withAnimation:delay:] instead?
> 
> I did, early on during my investigation.  I thought it just didn't work.  It
> turns out, there was a rogue call to -ensureOverlayHiddenWithAnimation:... 
I've
> now fixed that.  It still won't work if there are other rogue calls to either
of
> the -ensureOverlay* functions, but at least the locking mechanism allows
> multiple locks.
> 
> alwaysShowDropDown_ is removed, though what would you think about adding a
flag
> set by the browserWindowController's lock methods that this class could
DCHECK? 
> It might catch other rogue calls to -ensureOverlay*.

I'd prefer to not add a flag just for the sake of DCHECKing. Is there not enough
state that could be exposed by BrowserWindowController/Private to serve the same
purpose?

https://codereview.chromium.org/390503003/diff/60001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/browser_window_controller_private.h (right):

https://codereview.chromium.org/390503003/diff/60001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_controller_private.h:108: // allow the
floating bar to be hidden once there is no permission bubble
This sentence is awkward to read.

[leng, 2014-07-14 21:28:32]

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/presentation_mode_controller.h (right):

https://codereview.chromium.org/390503003/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/presentation_mode_controller.h:45: BOOL
alwaysShowDropdown_;
On 2014/07/14 20:22:31, rsesek wrote:
> On 2014/07/14 18:17:24, leng wrote:
> > On 2014/07/14 14:13:32, rsesek wrote:
> > > Have you looked at -[BrowserWindowController
> > > lockBarVisibilityForOwner:withAnimation:delay:] instead?
> > 
> > I did, early on during my investigation.  I thought it just didn't work.  It
> > turns out, there was a rogue call to -ensureOverlayHiddenWithAnimation:... 
> I've
> > now fixed that.  It still won't work if there are other rogue calls to
either
> of
> > the -ensureOverlay* functions, but at least the locking mechanism allows
> > multiple locks.
> > 
> > alwaysShowDropDown_ is removed, though what would you think about adding a
> flag
> > set by the browserWindowController's lock methods that this class could
> DCHECK? 
> > It might catch other rogue calls to -ensureOverlay*.
> 
> I'd prefer to not add a flag just for the sake of DCHECKing. Is there not
enough
> state that could be exposed by BrowserWindowController/Private to serve the
same
> purpose?

I don't think so, but don't feel that strongly about it.

https://codereview.chromium.org/390503003/diff/60001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/browser_window_controller_private.h (right):

https://codereview.chromium.org/390503003/diff/60001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_controller_private.h:108: // allow the
floating bar to be hidden once there is no permission bubble
On 2014/07/14 20:22:31, rsesek wrote:
> This sentence is awkward to read.

Edited;  hopefully better.

[Robert Sesek, 2014-07-15 16:38:16]

LGTM

https://codereview.chromium.org/390503003/diff/60001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/browser_window_controller_private.h (right):

https://codereview.chromium.org/390503003/diff/60001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/browser_window_controller_private.h:108: // allow the
floating bar to be hidden once there is no permission bubble
On 2014/07/14 21:28:32, leng wrote:
> On 2014/07/14 20:22:31, rsesek wrote:
> > This sentence is awkward to read.
> 
> Edited;  hopefully better.

Yes, much.

[leng, 2014-07-15 20:52:45]

@greg - ping?

[Greg Billock, 2014-07-17 18:39:13]

On 2014/07/15 20:52:45, leng wrote:
> @greg - ping?

LGTM

[leng, 2014-07-17 18:40:28]

The CQ bit was checked by leng@chromium.org

[commit-bot: I haz the power, 2014-07-17 18:43:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/leng@chromium.org/390503003/80001

[leng, 2014-07-17 18:53:00]

+rdsmith - OWNERS for chrome/browser/download

[commit-bot: I haz the power, 2014-07-17 22:18:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-07-17 22:25:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 22:25:51]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[leng, 2014-07-18 00:23:53]

+asanka for OWNERS - chrome/browser/download

-rdsmith - OOO

[Randy Smith (Not in Mondays), 2014-07-21 15:40:31]

lgtm

[leng, 2014-07-21 15:57:40]

The CQ bit was checked by leng@chromium.org

[commit-bot: I haz the power, 2014-07-21 15:58:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/leng@chromium.org/390503003/80001

[commit-bot: I haz the power, 2014-07-21 16:03:30]

Change committed as 284438