ui/base/cocoa/underlay_opengl_hosting_window.h - Issue 469003006: Remove --disable-core-animation flag

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/cocoa/underlay_opengl_hosting_window.h

Issue 469003006: Remove --disable-core-animation flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@erikchen_patch

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/cocoa/nsview_additions.mm ('K') | « chrome/chrome_tests_unit.gypi ('k') | ui/base/cocoa/underlay_opengl_hosting_window.mm » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_BASE_COCOA_UNDERLAY_OPENGL_HOSTING_WINDOW_H_	5 #ifndef UI_BASE_COCOA_UNDERLAY_OPENGL_HOSTING_WINDOW_H_

6 #define UI_BASE_COCOA_UNDERLAY_OPENGL_HOSTING_WINDOW_H_	6 #define UI_BASE_COCOA_UNDERLAY_OPENGL_HOSTING_WINDOW_H_

7	7

8 #import <Cocoa/Cocoa.h>	8 #import <Cocoa/Cocoa.h>

9	9

10 #include "ui/base/ui_base_export.h"	10 #include "ui/base/ui_base_export.h"

11	11

12 // Common base class for windows that host a OpenGL surface that renders under	12 // Common base class for windows that host a OpenGL surface that renders under

13 // the window. Contains methods relating to hole punching so that the OpenGL	13 // the window. Previously contained methods related to hole punching, now just

14 // surface is visible through the window.	14 // contains common asserts.
	Avi (use Gerrit) 2014/08/14 19:23:41 Yeah, we're going to need to figure out what to do Yeah, we're going to need to figure out what to do with this class.... ccameron 2014/08/14 19:34:39 I was thinking to rename it to WebContentHostingWi Show quoted text On 2014/08/14 19:23:41, Avi wrote: > Yeah, we're going to need to figure out what to do with this class.... I was thinking to rename it to WebContentHostingWindow and walk away, but it looks like that's over-stating its use (apps, for instance, don't use this as a window class). Maybe just changing its callers to just use NSWindow is the way to go. Avi (use Gerrit) 2014/08/14 19:57:27 For now, we can leave it as being vestigial, and w For now, we can leave it as being vestigial, and we'll figure out in a followup CL. Yeah, moving it to NSWindow is probably the best option.
15 UI_BASE_EXPORT	15 UI_BASE_EXPORT

16 @interface UnderlayOpenGLHostingWindow : NSWindow	16 @interface UnderlayOpenGLHostingWindow : NSWindow

17 @end	17 @end

18	18

19 #endif // UI_BASE_COCOA_UNDERLAY_OPENGL_HOSTING_WINDOW_H_	19 #endif // UI_BASE_COCOA_UNDERLAY_OPENGL_HOSTING_WINDOW_H_

OLD	NEW