Remove --disable-core-animation flag

chrome/browser/ui/cocoa/nsview_additions.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "base/command_line.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/sdk_forward_declarations.h"
 #import "chrome/browser/ui/cocoa/nsview_additions.h"
 #include "chrome/common/chrome_switches.h"
-#include "ui/base/ui_base_switches.h"
 #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h"
 
 #include "base/logging.h"
 
 @implementation NSView (ChromeAdditions)
 
 - (CGFloat)cr_lineWidth {
   // All shipping retina macs run at least 10.7.
   if (![self respondsToSelector:@selector(convertSizeFromBacking:)])
     return 1;
@@ skipping 42 matching lines @@
   return [[NSColor keyboardFocusIndicatorColor]
       colorWithAlphaComponent:0.5 / [self cr_lineWidth]];
 }
 
 - (void)cr_recursivelySetNeedsDisplay:(BOOL)flag {
   [self setNeedsDisplay:YES];
   for (NSView* child in [self subviews])
     [child cr_recursivelySetNeedsDisplay:flag];
 }
 
-- (void)cr_setWantsLayer:(BOOL)wantsLayer {
-  if (CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kDisableCoreAnimation))
-    return;
-
-  // Dynamically removing layers on SnowLeopard will sometimes result in
-  // crashes. Once a view has a layer on SnowLeopard, it is stuck with it.
-  // http://crbug.com/348328
-  if (!wantsLayer && base::mac::IsOSSnowLeopard())
-    return;

[Avi (use Gerrit), 2014/08/14 19:23:40]

Do we ever call setWantsLayer:NO? I'm hoping we don't lose any crash fixes with
this.

[ccameron, 2014/08/14 19:34:39]

We didn't call cr_setWantsLayer:NO (the previous call we had to it was a
disaster & was removed).

That said, https://codereview.chromium.org/390503003 added a call to
setWantsLayer:NO -- I don't see any evidence that this is causing problem in the
crash servers, but I'll keep my eye on it.

-
-  [self setWantsLayer:wantsLayer];
-}
-
 static NSView* g_ancestorBeingDrawnFrom = nil;
 static NSView* g_childBeingDrawnTo = nil;
 
 - (void)cr_drawUsingAncestor:(NSView*)ancestorView inRect:(NSRect)rect {
   gfx::ScopedNSGraphicsContextSaveGState scopedGSState;
   NSRect frame = [self convertRect:[self bounds] toView:ancestorView];
   NSAffineTransform* transform = [NSAffineTransform transform];
   if ([self isFlipped] == [ancestorView isFlipped]) {
     [transform translateXBy:-NSMinX(frame) yBy:-NSMinY(frame)];
   } else {
@@ skipping 12 matching lines @@
 }
 
 - (NSView*)cr_viewBeingDrawnTo {
   if (!g_ancestorBeingDrawnFrom)
     return self;
   DCHECK(g_ancestorBeingDrawnFrom == self);
   return g_childBeingDrawnTo;
 }
 
 @end