|
Browsing Data Deletion: Style fixes
These nits were noted when a new storage type was added in
crrev.com/394063003 and this CL applies those style changes and other
suggestions to the other files. Standardize on DCHECK(!x), use
DCHECK_CURRENTLY_ON() where possible, use empty() rather than !size(),
all the trivial cpplint.py findings, and add/use ASSERTs in mock
classes (vs. CHECK/DCHECKs)
No functional changes.
R=bauerb@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289010
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+212 lines, -154 lines) |
Patch |
 |
M |
chrome/browser/browsing_data/browsing_data_appcache_helper.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_appcache_helper.cc
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_channel_id_helper.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_channel_id_helper.cc
|
View
|
1
|
11 chunks |
+31 lines, -26 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_channel_id_helper_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_cookie_helper.h
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_cookie_helper.cc
|
View
|
|
10 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_database_helper.h
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_database_helper.cc
|
View
|
|
10 chunks |
+14 lines, -12 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_file_system_helper.cc
|
View
|
|
7 chunks |
+10 lines, -8 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_indexed_db_helper.h
|
View
|
1
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc
|
View
|
|
5 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_local_storage_helper.cc
|
View
|
|
4 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_remover.cc
|
View
|
|
16 chunks |
+24 lines, -23 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_remover_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_service_worker_helper.h
|
View
|
1
|
2 chunks |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/browsing_data_service_worker_helper_unittest.cc
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/cookies_tree_model.cc
|
View
|
|
12 chunks |
+17 lines, -26 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/cookies_tree_model_unittest.cc
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/local_data_container.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_appcache_helper.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_appcache_helper.cc
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.h
|
View
|
|
2 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc
|
View
|
|
2 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_cookie_helper.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_cookie_helper.cc
|
View
|
|
3 chunks |
+6 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_database_helper.h
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_database_helper.cc
|
View
|
|
3 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_file_system_helper.h
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_file_system_helper.cc
|
View
|
|
3 chunks |
+7 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_flash_lso_helper.h
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_flash_lso_helper.cc
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc
|
View
|
|
3 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.cc
|
View
|
|
3 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_quota_helper.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_quota_helper.cc
|
View
|
|
3 chunks |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/browsing_data/mock_browsing_data_service_worker_helper.cc
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|