Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.cc

Issue 459233002: Browsing Data Deletion: Style fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-apply comment tweaks Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.cc
diff --git a/chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.cc b/chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.cc
index cf9cd28b8e12fed683dffd0f2784878ba8b613ba..ccb0b72017e79111f073579b80a35e0cd53de97d 100644
--- a/chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.cc
+++ b/chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.cc
@@ -6,6 +6,7 @@
#include "base/callback.h"
#include "base/logging.h"
+#include "testing/gtest/include/gtest/gtest.h"
MockBrowsingDataLocalStorageHelper::MockBrowsingDataLocalStorageHelper(
Profile* profile)
@@ -17,12 +18,15 @@ MockBrowsingDataLocalStorageHelper::~MockBrowsingDataLocalStorageHelper() {
void MockBrowsingDataLocalStorageHelper::StartFetching(
const base::Callback<void(const std::list<LocalStorageInfo>&)>& callback) {
+ ASSERT_FALSE(callback.is_null());
+ ASSERT_TRUE(callback_.is_null());
callback_ = callback;
}
void MockBrowsingDataLocalStorageHelper::DeleteOrigin(
const GURL& origin) {
- CHECK(origins_.find(origin) != origins_.end());
+ ASSERT_FALSE(callback_.is_null());
+ ASSERT_TRUE(origins_.find(origin) != origins_.end());
last_deleted_origin_ = origin;
origins_[origin] = false;
}
@@ -41,7 +45,6 @@ void MockBrowsingDataLocalStorageHelper::AddLocalStorageSamples() {
}
void MockBrowsingDataLocalStorageHelper::Notify() {
- CHECK_EQ(false, callback_.is_null());
callback_.Run(response_);
}

Powered by Google App Engine
This is Rietveld 408576698