Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: chrome/browser/browsing_data/browsing_data_appcache_helper.cc

Issue 459233002: Browsing Data Deletion: Style fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-apply comment tweaks Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_appcache_helper.cc
diff --git a/chrome/browser/browsing_data/browsing_data_appcache_helper.cc b/chrome/browser/browsing_data/browsing_data_appcache_helper.cc
index 8fb5d42ae166b06b9bdd02a92b1f6bdfbab4fc39..ddb9c709b0cb1b66b2279f49d73e264d210a5e70 100644
--- a/chrome/browser/browsing_data/browsing_data_appcache_helper.cc
+++ b/chrome/browser/browsing_data/browsing_data_appcache_helper.cc
@@ -25,7 +25,7 @@ BrowsingDataAppCacheHelper::BrowsingDataAppCacheHelper(Profile* profile)
void BrowsingDataAppCacheHelper::StartFetching(const base::Closure& callback) {
if (BrowserThread::CurrentlyOn(BrowserThread::UI)) {
DCHECK(!is_fetching_);
- DCHECK_EQ(false, callback.is_null());
+ DCHECK(!callback.is_null());
is_fetching_ = true;
info_collection_ = new content::AppCacheInfoCollection;
completion_callback_ = callback;
@@ -35,7 +35,7 @@ void BrowsingDataAppCacheHelper::StartFetching(const base::Closure& callback) {
return;
}
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
appcache_info_callback_.Reset(
base::Bind(&BrowsingDataAppCacheHelper::OnFetchComplete,
base::Unretained(this)));
@@ -79,7 +79,7 @@ void BrowsingDataAppCacheHelper::OnFetchComplete(int rv) {
return;
}
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(is_fetching_);
is_fetching_ = false;
completion_callback_.Run();
@@ -94,7 +94,7 @@ CannedBrowsingDataAppCacheHelper::CannedBrowsingDataAppCacheHelper(
}
CannedBrowsingDataAppCacheHelper* CannedBrowsingDataAppCacheHelper::Clone() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
CannedBrowsingDataAppCacheHelper* clone =
new CannedBrowsingDataAppCacheHelper(profile_);

Powered by Google App Engine
This is Rietveld 408576698