Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Unified Diff: chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc

Issue 459233002: Browsing Data Deletion: Style fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-apply comment tweaks Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc
diff --git a/chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc b/chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc
index c40a1951d259fa913b489595a4b182e96def2d0a..ab74111970bf4c6dc2ac62a43e7e49c4c4d93cc3 100644
--- a/chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc
+++ b/chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/profiles/profile.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/storage_partition.h"
+#include "testing/gtest/include/gtest/gtest.h"
MockBrowsingDataIndexedDBHelper::MockBrowsingDataIndexedDBHelper(
Profile* profile)
@@ -23,12 +24,15 @@ MockBrowsingDataIndexedDBHelper::~MockBrowsingDataIndexedDBHelper() {
void MockBrowsingDataIndexedDBHelper::StartFetching(
const base::Callback<void(const std::list<content::IndexedDBInfo>&)>&
callback) {
+ ASSERT_FALSE(callback.is_null());
+ ASSERT_TRUE(callback_.is_null());
callback_ = callback;
}
void MockBrowsingDataIndexedDBHelper::DeleteIndexedDB(
const GURL& origin) {
- CHECK(origins_.find(origin) != origins_.end());
+ ASSERT_FALSE(callback_.is_null());
+ ASSERT_TRUE(origins_.find(origin) != origins_.end());
origins_[origin] = false;
}
@@ -44,7 +48,6 @@ void MockBrowsingDataIndexedDBHelper::AddIndexedDBSamples() {
}
void MockBrowsingDataIndexedDBHelper::Notify() {
- CHECK_EQ(false, callback_.is_null());
callback_.Run(response_);
}

Powered by Google App Engine
This is Rietveld 408576698