Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: chrome/browser/browsing_data/mock_browsing_data_cookie_helper.cc

Issue 459233002: Browsing Data Deletion: Style fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-apply comment tweaks Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/mock_browsing_data_cookie_helper.cc
diff --git a/chrome/browser/browsing_data/mock_browsing_data_cookie_helper.cc b/chrome/browser/browsing_data/mock_browsing_data_cookie_helper.cc
index b8511e047192bf2e316086a9115e31a3061b2b3f..5e95faa71c217b91979217d5ae8ef59ae6bf32f1 100644
--- a/chrome/browser/browsing_data/mock_browsing_data_cookie_helper.cc
+++ b/chrome/browser/browsing_data/mock_browsing_data_cookie_helper.cc
@@ -7,6 +7,7 @@
#include "base/logging.h"
#include "net/cookies/canonical_cookie.h"
#include "net/cookies/parsed_cookie.h"
+#include "testing/gtest/include/gtest/gtest.h"
MockBrowsingDataCookieHelper::MockBrowsingDataCookieHelper(
net::URLRequestContextGetter* request_context_getter)
@@ -18,13 +19,16 @@ MockBrowsingDataCookieHelper::~MockBrowsingDataCookieHelper() {
void MockBrowsingDataCookieHelper::StartFetching(
const net::CookieMonster::GetCookieListCallback &callback) {
+ ASSERT_FALSE(callback.is_null());
+ ASSERT_TRUE(callback_.is_null());
callback_ = callback;
}
void MockBrowsingDataCookieHelper::DeleteCookie(
const net::CanonicalCookie& cookie) {
+ ASSERT_FALSE(callback_.is_null());
std::string key = cookie.Name() + "=" + cookie.Value();
- CHECK(cookies_.find(key) != cookies_.end());
+ ASSERT_TRUE(cookies_.find(key) != cookies_.end());
cookies_[key] = false;
}
@@ -38,7 +42,7 @@ void MockBrowsingDataCookieHelper::AddCookieSamples(
for (cookie_iterator cookie = cookie_list_.begin();
cookie != cookie_list_.end(); ++cookie) {
if (cookie->Name() == cc->Name() &&
- cookie->Domain() == cc->Domain()&&
+ cookie->Domain() == cc->Domain() &&
cookie->Path() == cc->Path()) {
return;
}

Powered by Google App Engine
This is Rietveld 408576698