Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc

Issue 459233002: Browsing Data Deletion: Style fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Re-apply comment tweaks Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc
diff --git a/chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc b/chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc
index be20c68f10f3fb1916244fd3f8d306880ea41452..dd20a8c8f28771828e0e0da93c99aa5409f1ea21 100644
--- a/chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc
+++ b/chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.h"
#include "base/logging.h"
+#include "testing/gtest/include/gtest/gtest.h"
MockBrowsingDataChannelIDHelper::MockBrowsingDataChannelIDHelper()
: BrowsingDataChannelIDHelper() {}
@@ -14,18 +15,21 @@ MockBrowsingDataChannelIDHelper::
void MockBrowsingDataChannelIDHelper::StartFetching(
const FetchResultCallback& callback) {
+ ASSERT_FALSE(callback.is_null());
+ ASSERT_TRUE(callback_.is_null());
callback_ = callback;
}
void MockBrowsingDataChannelIDHelper::DeleteChannelID(
const std::string& server_id) {
- CHECK(channel_ids_.find(server_id) != channel_ids_.end());
+ ASSERT_FALSE(callback_.is_null());
+ ASSERT_TRUE(channel_ids_.find(server_id) != channel_ids_.end());
channel_ids_[server_id] = false;
}
void MockBrowsingDataChannelIDHelper::AddChannelIDSample(
const std::string& server_id) {
- DCHECK(channel_ids_.find(server_id) == channel_ids_.end());
+ ASSERT_TRUE(channel_ids_.find(server_id) == channel_ids_.end());
channel_id_list_.push_back(
net::ChannelIDStore::ChannelID(
server_id, base::Time(), base::Time(), "key", "cert"));

Powered by Google App Engine
This is Rietveld 408576698