Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 449413002: DevTools: DataGrid: turn "element" getter to function. (Closed)

Created:
6 years, 4 months ago by eustas
Modified:
6 years, 4 months ago
Reviewers:
vsevik, lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: DataGrid: turn "element" getter to function. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179842

Patch Set 1 #

Patch Set 2 : #

Messages

Total messages: 10 (0 generated)
eustas
6 years, 4 months ago (2014-08-08 08:58:13 UTC) #1
lushnikov
lgtm
6 years, 4 months ago (2014-08-08 09:52:20 UTC) #2
vsevik
lgtm
6 years, 4 months ago (2014-08-08 11:30:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/449413002/1
6 years, 4 months ago (2014-08-08 11:31:41 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-08 13:00:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 13:25:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/19746)
6 years, 4 months ago (2014-08-08 13:25:57 UTC) #7
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 4 months ago (2014-08-08 13:59:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/449413002/20001
6 years, 4 months ago (2014-08-08 14:00:52 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 16:05:43 UTC) #10
Message was sent while issue was closed.
Change committed as 179842

Powered by Google App Engine
This is Rietveld 408576698