Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1932)

Unified Diff: Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

Issue 449413002: DevTools: DataGrid: turn "element" getter to function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js
diff --git a/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js b/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js
index c35b7fa33d455ecd9aa6e43ad769b414e773a0eb..8c8b2cd32851a1650cdce785fabd3398dfeb61fe 100644
--- a/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js
+++ b/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js
@@ -171,7 +171,7 @@ WebInspector.HeapSnapshotSortableDataGrid.prototype = {
var prevNode = this._highlightedNode;
this._clearCurrentHighlight();
this._highlightedNode = node;
- WebInspector.runCSSAnimationOnce(this._highlightedNode.element, "highlighted-row");
+ WebInspector.runCSSAnimationOnce(this._highlightedNode.element(), "highlighted-row");
},
nodeWasDetached: function(node)
@@ -184,7 +184,7 @@ WebInspector.HeapSnapshotSortableDataGrid.prototype = {
{
if (!this._highlightedNode)
return
- this._highlightedNode.element.classList.remove("highlighted-row");
+ this._highlightedNode.element().classList.remove("highlighted-row");
this._highlightedNode = null;
},
@@ -523,11 +523,11 @@ WebInspector.HeapSnapshotViewportDataGrid.prototype = {
*/
highlightNode: function(node)
{
- if (this._isScrolledIntoView(node.element)) {
+ if (this._isScrolledIntoView(node.element())) {
this.updateVisibleNodes(true);
WebInspector.HeapSnapshotSortableDataGrid.prototype.highlightNode.call(this, node);
} else {
- node.element.scrollIntoViewIfNeeded(true);
+ node.element().scrollIntoViewIfNeeded(true);
this._nodeToHighlightAfterScroll = node;
}
},
« no previous file with comments | « Source/devtools/front_end/profiler/CanvasReplayStateView.js ('k') | Source/devtools/front_end/ui/DataGrid.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698